Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't URL encode slash in [githubactionsworkflow] badge #9322

Merged
merged 2 commits into from Jul 3, 2023
Merged

don't URL encode slash in [githubactionsworkflow] badge #9322

merged 2 commits into from Jul 3, 2023

Conversation

chris48s
Copy link
Member

closes #9315

Interestingly, in setting up a repo with some test workflows, I discovered that putting workflows in a subdirectory under .github/workflows doesn't work. So that's probably why we've never seen this before 💡

@chris48s chris48s added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Jun 26, 2023
@github-actions
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 61491f9

calebcartwright
calebcartwright approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to doing this categorically 👍

I suppose it could be conditionally special cased (only when the path starts with pages), but I don't think there's any remotely meaningful/observable differences between the two approaches at execution time

@repo-ranger repo-ranger bot merged commit e7197f6 into badges:master Jul 3, 2023
21 checks passed
@krlmlr krlmlr mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github actions workflow badge returns "unparseable svg response" for (some?) workflows containing slash
2 participants
@chris48s @calebcartwright