Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [pypi] status badge when package has no 'Development Status' classifier #10107

Merged
merged 1 commit into from May 6, 2024

Conversation

chris48s
Copy link
Member

Currently if we request this badge for a package with no 'Development Status' classifier we render an 'empty' badge

e.g: - https://img.shields.io/pypi/status/arcgis2geojson/3.0.2

This PR fixes that

@chris48s chris48s added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Apr 21, 2024
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 5742af9

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little improvement for this edge case! 👍🏻

@chris48s chris48s added this pull request to the merge queue May 6, 2024
Merged via the queue into badges:master with commit 2857d9b May 6, 2024
22 checks passed
@chris48s chris48s deleted the pypi-status branch May 6, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants