Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GitHub] update description of commit status badge #10198

Merged
merged 4 commits into from
May 26, 2024
Merged

[GitHub] update description of commit status badge #10198

merged 4 commits into from
May 26, 2024

Conversation

mbtools
Copy link
Contributor

@mbtools mbtools commented May 25, 2024 •
edited
Loading

As discussed in #4364 (comment), this updates the description of the badge related to the Commit Status API.

Similarly to the new Check Run badge, I expanded to three use cases: branch, commit, tag.

Old:

GitHub tag checks state
GitHub pull request checks state

New:

GitHub tag status
GitHub commit status
GitHub branch status
GitHub pull request status

Closes #4364

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 25, 2024 •
edited
Loading

Warnings
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @mbtools!

Generated by 🚫 dangerJS against 2abf683

@PyvesB
Copy link
Member

PyvesB commented May 26, 2024

Test failure is unrelated, and should be fixed by #10200.

@PyvesB
Copy link
Member

PyvesB commented May 26, 2024

Should we also update the description of the GitHub pull request check badge? 🤔

PyvesB
PyvesB approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these examples/documentation updates! 🎉

@PyvesB PyvesB merged commit 427b24c into badges:master May 26, 2024
21 of 23 checks passed
@mbtools mbtools deleted the check_status branch May 26, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge Request: GitHub Check Runs Status
2 participants
@mbtools @PyvesB