Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis-CI logo #1276

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Add Travis-CI logo #1276

merged 1 commit into from
Nov 19, 2017

Conversation

RedSparr0w
Copy link
Member

Adds the Travis-CI logo

Closes #1107 - also discussion on there to decide which logo & color to use


@1.5x
@2x

image
image
image
image

Doesn't show well on the social style badge, but don't see it ever being used on that.

Should be ready for merge, will leave open for the day in case anyone notices anything that they think should be changed.

@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Nov 18, 2017
@RedSparr0w RedSparr0w merged commit ea061e5 into badges:master Nov 19, 2017
@RedSparr0w RedSparr0w deleted the travis-logo branch November 19, 2017 21:05
@olivierlacan
Copy link
Member

Hey @paulmelnikow. Just heard from Travis CI folks that alterations or unapproved uses of their logo are not something they've approved. This is one more nail in the "service logos in Shields badges" coffin for me. Can we make a plan to revert this change or deprecate this badge to replace it with the normal Travis CI build badge so we don't break people's stuff?

@RedSparr0w
Copy link
Member Author

If we revert this commit, it will just fallback to the simple-icons logo.
Looks like we may have to implement some kind of blacklist for cases where a company request their logos not be used on shields.io badges.

@paulmelnikow
Copy link
Member

@RedSparr0w or @chris48s, what do you think about reaching out to the Travis folks to see if we can resolve this? We've worked with them in the past, and it would be great to settle on something mutually agreeable. Of course if they don't want us to support it by keyword we can block it.

@RedSparr0w
Copy link
Member Author

I agree we would be best to reach out first and see if we can come to some agreement, they may even have an alternative logo they would prefer.

@olivierlacan
Copy link
Member

In general, I'd much prefer if we stopped including any company logos in badges. Any logo usage like this is likely to be a violation of brand guidelines at the very least. At worst, like in this case, it's a misuse of copyrighted or trademarked assets. I've explained a long time ago why I think logos are at cross-purpose with the idea of Shields.

I've yet to see a usage of a service logo that made me reconsider this: https://github.com/badges/shields/blob/master/spec/SPECIFICATION.md

Aside from the legal/contractual perspective, I still think logos are aesthetically problematic because we have limited range design-wise to accommodate their design within our own badge designs. But beyond the aesthetic consideration focusing on the service companies and their logo design, I think their logos compromise the Shields badge design(s) itself.

@RedSparr0w you can reach out Travis CI folks directly if you want but their policy on the matter is pretty clear: https://travis-ci.com/logo

image

The fact that they reached out to me directly and chose not to start a conversation here makes me thing that perhaps we should take the hint.

@chris48s
Copy link
Member

chris48s commented Feb 8, 2019

screenshot at 2019-02-08 20-31-18

I think we are using their logo to "show that [our] application or product integrates with Travis CI" (by calling their API) and that it is there so that our users can "use the logo to show [they're] running [their] tests on Travis CI". Perhaps if one of us offered to get a tattoo, or bake them some cookies it might smooth things over? 😉

That said, I don't really care to pursue it myself (or get a tattoo). If one of you wants to fight that battle, feel free. I'd probably just delete the logo and blacklist it so we won't use the simple-icons version.

@paulmelnikow
Copy link
Member

paulmelnikow commented Feb 18, 2019

I'd prefer that someone reach out to Travis and try to get their permission to continue to use the logo, because users who depend on the logo will come back and read this discussion, and it will be harder to reach out to Travis then.

That said, if none of the maintainers want to do that, then let's remove it promptly, and block it from being loaded via simple-icons.

We've never had a company complain before, so I don't see a pressing need for us to act immediately beyond this badge. We've supported the logos for a long time, they're popular, and other badge services provide them, which means (company requests aside) the decision to remove them from Shields should be made by the community. (Given the popularity of logos, would removing them drive users to other services? If so, would the net effect of those users walking away be more uniformity or less?)

Some other things we can do to "reel things in," so to speak:

  1. Document best practices for using badges (Document badge best practices #2868)
  2. Incorporate a statement on design philosophy into the project, and create guidelines about how we deal with the badge format.
    1. Vendor in or at least quote Olivier's "rage diamond" blog post might be a good idea, too.
  3. Create a design review process for changes to the badge designs
  4. Consider removing styles which are rarely used (like popout* and plastic)

@BanzaiMan
Copy link

Hello, there. So, the violation here is: "Alter the logo in any way". The logo we encourage others to use are shown on the logo page, and it unfortunately does not include a mono-colored one.

Aesthetically speaking, Mr. T is a little too busy (too many intricate lines) to look really good with a single color in a very tight space such as the badge.

We want to make this easier for our users, of course, but that would take some time. So, in the mean time, we appreciate it if you could remove Mr. T.

Thank you for your understanding and cooperation.

@paulmelnikow
Copy link
Member

Hi! Thanks so much for the clarification!

One question: Am I correct that you're okay with us using the full color or grayscale versions that are published on that page?

@BanzaiMan
Copy link

You mean this one, right?

Yes. But, as I said before, this won't look good if you shrink it too much.

@paulmelnikow
Copy link
Member

It's not great, though I think some users would find it better than nothing until Travis approves something new. I think if we check it in logoColor would be ignored and so it'll always show this color.

What do you think @RedSparr0w @chris48s?

@RedSparr0w
Copy link
Member Author

IMO the full color looks better, but the grayscale isn't bad.

1x 2x

@BanzaiMan
Copy link

🤔 Let me ask that question internally, and get back to you.

@paulmelnikow
Copy link
Member

@BanzaiMan It seems like using the logos from that page in the posted colors should be in line with the guidelines. Can you confirm? Thanks so much!

@BanzaiMan
Copy link

Hello, there. I've asked internally, as promised, and came to the conclusion that, among the choices given in @RedSparr0w's comment #1276 (comment), the full color version is the best.

I hope this clarifies the situation. Let me know if you have further questions. Thank you!

@paulmelnikow
Copy link
Member

Fabulous. Glad to hear that! Thanks so much!

paulmelnikow pushed a commit that referenced this pull request Feb 22, 2019
Switch Travis to use full-color logo approved at #1276 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants