Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete old tutorial and future TODOs #1983

Merged
merged 6 commits into from
Sep 2, 2018
Merged

Obsolete old tutorial and future TODOs #1983

merged 6 commits into from
Sep 2, 2018

Conversation

niccokunzmann
Copy link
Contributor

This obsoletes the implementation part of the tutorial.
As mentioned in #1958 (review),
old style badges should be avoided and new style badges are preferred.

@niccokunzmann
Obsolete old tutorial and future TODOs
dcd06d5 
This obsoletes the implementation part of the tutorial.
As mentioned in badges#1958 (review), 
old style badges should be avoided and new style badges are preferred.
@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @niccokunzmann!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

paulmelnikow
paulmelnikow reviewed Aug 27, 2018
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since f-droid isn't merged yet and review isn't finished, I'd rather not link to it. Other than that I'm good with merging this. It doesn't hurt!

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Aug 27, 2018
@niccokunzmann
Copy link
Contributor Author

niccokunzmann commented Aug 27, 2018 •
edited

I would like to replace it with a link to a pull request of a service. Is there one?
This can be merged.

@paulmelnikow
Copy link
Member

You could link to #1920 which is a good example of a simple rewrite, and/or #1940 which is more complex, as you see fit. I don't have a good example of a brand new badge that went in using the new format, because we've tended to tweak the service design as we go.

@niccokunzmann
Copy link
Contributor Author

@paulmelnikow You can merge it.

@paulmelnikow paulmelnikow merged commit e25e748 into badges:master Sep 2, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

chris48s added a commit to chris48s/shields that referenced this pull request Sep 4, 2018
@chris48s
Revert "Obsolete old tutorial and future TODOs (badges#1983)"
7cf25b8 
This reverts commit e25e748.
@dependabot-preview dependabot-preview bot mentioned this pull request Dec 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niccokunzmann @shields-ci @paulmelnikow