Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for VSTS build badges #2065

Merged
merged 3 commits into from
Sep 10, 2018
Merged

Conversation

Thilas
Copy link
Contributor

@Thilas Thilas commented Sep 8, 2018

Newly created build definitions on VSTS does not support old badge endpoint. Instead, a new one has been provided and supports all build definitions.

@shields-ci
Copy link

Warnings
⚠️

This PR modified service code for vso but not its test code.
That's okay so long as it's refactoring existing code.

Messages
📖

✨ Thanks for your contribution to Shields, @Thilas!

Generated by 🚫 dangerJS

@Thilas
Copy link
Contributor Author

Thilas commented Sep 10, 2018

@PyvesB, thanks for the review. Will you also merge the PR? Thanks!

@PyvesB PyvesB merged commit 2c04a63 into badges:master Sep 10, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@Thilas Thilas deleted the enhance-vsts-badges branch October 27, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants