improve [appveyor] error handling #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
reviewed
Sep 16, 2018
There was a problem hiding this comment.
If my understanding is correct, we could have an "unknown" badge in these two cases:
- the build status returned by Appveyor is "unknown".
- there are no builds.
Wouldn't it be even better to separate the two and be extra clear in the second case, for instance by saying "no builds found" or something similar?
PyvesB
approved these changes
Sep 17, 2018
PyvesB
added
the
service-badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows an 'unknown' build status if we get a response with no
buildkey. Closes #2073