refactor arch user repositories [aur] service #2086
Conversation
| class AurVersion extends BaseAurService { | ||
| static render({ version, outOfDate }) { | ||
| const color = outOfDate === null ? 'blue' : 'orange' | ||
| return { message: versionText(version), color: color } |
There was a problem hiding this comment.
I've intentionally not used renderVersionBadge() here because we're using colour to convey a different meaning here
Generated by 🚫 dangerJS |
chris48s
added
the
service-badge
|
We seem to usually break down different badges implementations into different files, shouldn't we have version, votes and license separated? |
|
We've got a mix. For some services we've got the base class in one file and each service in its own file, but for example APM also defines 3 badge classes in one file: shields/services/apm/apm.service.js Lines 157 to 161 in 264f5e3 I definitely wouldn't want to define a large service family like NPM or PyPI all in one file, but I reckon when we're dealing with a couple hundred lines of code its fine. I guess its a matter of taste though. |
|
Fair enough. I'm a bit short on time at the moment, but will aim at reviewing this more carefully later during the week. 😉 |
services/aur/aur.service.js
Outdated
| results: Joi.alternatives( | ||
| Joi.array() | ||
| .min(0) | ||
| .max(0) |
There was a problem hiding this comment.
I believe you could simply use length(0) here.
services/aur/aur.tester.js
Outdated
| @@ -16,7 +15,7 @@ t.create('version (valid)') | |||
| .get('/version/yaourt.json?style=_shields_test') | |||
| .expectJSONTypes( | |||
| Joi.object().keys({ | |||
| name: 'aur', | |||
| name: 'version', | |||
There was a problem hiding this comment.
I'm somewhat confused here. Why has the label changed to version?
There was a problem hiding this comment.
Good question. Looking over the examples we usually use the platform name as the label on version badges so I shouldn't have changed this.
chris48s
changed the title
|
cheers :) |
Refs #1358
This PR ports the Arch User Repositories integration to the new service architecture.