Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized license file #2146

Merged
merged 2 commits into from Oct 5, 2018
Merged

Standardized license file #2146

merged 2 commits into from Oct 5, 2018

Conversation

platan
Copy link
Member

@platan platan commented Oct 3, 2018

Problem is described in #1666
GitHub is using https://github.com/benbalter/licensee in license detection (https://blog.github.com/2016-09-21-license-now-displayed-on-repository-overview/)

Current state

# branch master 
git --no-pager log --format="%H" -n 1
345d6222fc85af659b69847567e6f851d835fb0e

licensee detect LICENSE.md           
License:        NOASSERTION
Matched files:  LICENSE.md
LICENSE.md:
  Content hash:  1f1af19a4e586556c57466d4ec1a90f7ecaf460b
  License:       NOASSERTION

1st attempt
I've removed non standard fragment in out license file, diff https://github.com/badges/shields/compare/master...platan:standardized-license-1?expand=1

licensee detect LICENSE.md
License:        NOASSERTION
Matched files:  LICENSE.md
LICENSE.md:
  Content hash:  506c59e044a13782f7794e05a1090edc53091b40
  License:       NOASSERTION
  Closest non-matching licenses:
    CC0-1.0 similarity:  97.44%

2nd attempt
I've removed non standard fragment + I've changed license name (name from https://choosealicense.com/licenses/cc0-1.0/), diff https://github.com/platan/shields/compare/master...platan:standardized-license-2?expand=1

licensee detect LICENSE.md           
CC0 1.0 Universal
https://choosealicense.com/licenses/cc0-1.0/
License:        CC0-1.0
Matched files:  LICENSE.md
LICENSE.md:
  Content hash:  705e13a9e0c173fe8dbeb3a56ed57022550534d5
  Confidence:    98.01%
  Matcher:       Licensee::Matchers::Dice
  License:       CC0-1.0
  Closest non-matching licenses:
    CC0-1.0 similarity:  98.01%

3rd attempt - this PR
I've moved LICENSE.md to LICENSE and I've put content from https://choosealicense.com/licenses/cc0-1.0/ in it.

licensee detect LICENSE.md           
License:        CC0-1.0
Matched files:  LICENSE
LICENSE:
  Content hash:  83624ed81a5eea4456349757fe58ac7f721c154e
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       CC0-1.0

After merge GH should detect our license properly. It does not do it on branch https://github.com/platan/shields/blob/standardized-license-3/LICENSE

@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @platan!

📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look at this 👍 Sounds like it was a bit more fiddly than it needed to be

@platan platan added the developer-experience Dev tooling, test framework, and CI label Oct 4, 2018
@platan platan merged commit 9b5ca7d into badges:master Oct 5, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@platan
Copy link
Member Author

platan commented Oct 5, 2018

It works :-) https://github.com/badges/shields/blob/master/LICENSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants