Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise discord logo, change default colour #2874

Merged
merged 2 commits into from
Jan 26, 2019

Conversation

chris48s
Copy link
Member

Our discord icon is clearer than the simple-icons version. I've applied the same optimisations here that I did in #2873 but I'm also wondering if its better to change the default colour so the logo is visible on both badge styles by default. I can roll that back and keep it white if we want..

before:

after:

@shields-ci
Copy link

shields-ci commented Jan 25, 2019

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against c90bd9d

@chris48s chris48s mentioned this pull request Jan 25, 2019
3 tasks
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@paulmelnikow paulmelnikow requested a deployment to shields-staging-pr-2874 January 26, 2019 17:52 Abandoned
@chris48s chris48s merged commit 2937901 into badges:master Jan 26, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants