Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete LGTM logo #2919

Merged
merged 2 commits into from
Feb 4, 2019
Merged

delete LGTM logo #2919

merged 2 commits into from
Feb 4, 2019

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Feb 4, 2019

Before:

After:

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Feb 4, 2019
@shields-ci
Copy link

shields-ci commented Feb 4, 2019

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 0491d95

@chris48s chris48s merged commit 566a8cb into badges:master Feb 4, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow
Copy link
Member

Wonder if we ought to run this by them, as they're promoting the Shields badge as their official badge.

@paulmelnikow
Copy link
Member

Hey @samlanning,

For context, this is part of a laborious process in which @chris48s has contributed most of the Shields-maintained logos to a project called https://simpleicons.org/. That project is both widely available, and is kept up to date by people other than us 😄 See #2510 for that discussion.

This has already been helpful, e.g. our Slack logo is getting a bump for free.

The logos from simple-icons are monochrome, so we use the brand color when it works on the background, and replace it with a basic light or dark color when it provides too little contrast. (#2833)

The result is the lgtm logo is now monochrome. It renders a little differently on the regular badges, and is visible on the social badge (whereas it was completely invisible before).

Are you cool with this? Would be great to hear from you before this goes live.

@chris48s
Copy link
Member Author

chris48s commented Feb 5, 2019

If you need to revert this change to deploy, go for it

@paulmelnikow
Copy link
Member

Let's not block on it. We can revisit and quickly redeploy if needed.

@s0
Copy link
Contributor

s0 commented Feb 6, 2019

Hey @paulmelnikow thanks for looping me in on this.

In general I'm pretty happy with this change, monochrome logo looks good to me.

The one subtle thing with our logo is that when the colours are inverted, the tarsier's head looks a little ghostly / skull like (and its eyes look spooky). So as part of our branding guidelines, we generally have 2 logo alternatives for light and dark backgrounds. But given that at least for shields.io the white is what we want, and it looks good, this LGTM. I'll consider working with simpleicons re: light and dark alternatives for icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants