-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dependabot logo #2931
Update Dependabot logo #2931
Conversation
|
Hello @feelepxyz, Thank you for your contribution to Shields. However, this logo is now part of simple-icons, which is an icon set supported by Shields. Therefore, should we maybe remove our own version instead? Cheers, Pyves |
@PyvesB ah cool didn't know about simple-icons, will update that one too. I would rather use the current one in this PR for Shields (without the hexagon) - it will look much better in the badge than the full version in simple-icons. |
@chris48s what's your take on this? |
Dependabot was one of the services where we kept a custom logo instead of using the simple-icons one. The custom version is clearer at small size and is the same one dependabot use on their own badge: I actually used the dependabot logo as an example in the logo tests, which is why changing the logo has cause the the build to fail 😄 so I'm going to push a couple of fixup commits - one to minify the logo and one to fix the tests, but thanks for updating us with the new design 👍 |
oh, and the new logo: before: https://svgshare.com/s/AWP |
@chris48s amazing! Thanks for fixing it up!
…On Wed, 6 Feb 2019 at 20:31, chris48s ***@***.***> wrote:
oh, and the new logo:
<https://camo.githubusercontent.com/c39027cbea9c21bf802ab892797484702171aed3/68747470733a2f2f73766773686172652e636f6d2f692f42324e2e737667>
looks almost the same at this size, but it is subtly rounder :)
before: https://svgshare.com/s/AWP
after: http://svgshare.com/s/B2N
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2931 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABOxckA94N67g2mu3cbMVmNvsHNXUvNks5vKzuwgaJpZM4ajtRt>
.
|
Hey, we've just rolled out an updated logo on Dependabot and would like to update it here too 🤖
Preview with background colour