Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependabot logo #2931

Merged
merged 6 commits into from
Feb 6, 2019
Merged

Update Dependabot logo #2931

merged 6 commits into from
Feb 6, 2019

Conversation

feelepxyz
Copy link
Contributor

Hey, we've just rolled out an updated logo on Dependabot and would like to update it here too 🤖

Preview with background colour

screen shot 2019-02-05 at 17 27 01

@shields-ci
Copy link

shields-ci commented Feb 5, 2019

Messages
📖 ✨ Thanks for your contribution to Shields, @feelepxyz!

Generated by 🚫 dangerJS against 5e74a4b

@PyvesB
Copy link
Member

PyvesB commented Feb 5, 2019

Hello @feelepxyz,

Thank you for your contribution to Shields. However, this logo is now part of simple-icons, which is an icon set supported by Shields. Therefore, should we maybe remove our own version instead?

Cheers,

Pyves

@feelepxyz
Copy link
Contributor Author

@PyvesB ah cool didn't know about simple-icons, will update that one too.

I would rather use the current one in this PR for Shields (without the hexagon) - it will look much better in the badge than the full version in simple-icons.

@PyvesB
Copy link
Member

PyvesB commented Feb 6, 2019

@chris48s what's your take on this?

@chris48s
Copy link
Member

chris48s commented Feb 6, 2019

Dependabot was one of the services where we kept a custom logo instead of using the simple-icons one. The custom version is clearer at small size and is the same one dependabot use on their own badge:

simple-icons:
https://svgshare.com/s/AVi

shields:
https://svgshare.com/s/AWP

I actually used the dependabot logo as an example in the logo tests, which is why changing the logo has cause the the build to fail 😄 so I'm going to push a couple of fixup commits - one to minify the logo and one to fix the tests, but thanks for updating us with the new design 👍

@chris48s
Copy link
Member

chris48s commented Feb 6, 2019

oh, and the new logo:
looks almost the same at this size, but it is subtly rounder :)

before: https://svgshare.com/s/AWP
after: http://svgshare.com/s/B2N

@feelepxyz
Copy link
Contributor Author

feelepxyz commented Feb 6, 2019 via email

@chris48s chris48s merged commit cf7b76d into badges:master Feb 6, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants