Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor [Bitbucket] pull request #3649

Merged
merged 2 commits into from Jul 5, 2019
Merged

Refactor [Bitbucket] pull request #3649

merged 2 commits into from Jul 5, 2019

Conversation

paulmelnikow
Copy link
Member

This encapsulates the fetch methods slightly better. Cherrypicked from #3410, which needs to be reworked. This change should simplify dropping in the new auth method when that happens.

@paulmelnikow
Refactor [BitbucketPullRequest]
6a1806a 
Cherrypicked from #3410, which needs to be reworked.
@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Jul 5, 2019
@shields-cd shields-cd temporarily deployed to shields-staging-pr-3649 July 5, 2019 20:25 Inactive
@shields-ci
Copy link

shields-ci commented Jul 5, 2019 •
edited

Warnings
⚠️ This PR modified service code for bitbucket but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

📚 Remember to ensure any changes to serverSecrets in services/bitbucket/bitbucket-pull-request.service.js are reflected in the server secrets documentation
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 549be61

@paulmelnikow paulmelnikow changed the title Refactor [BitbucketPullRequest] Refactor [Bitbucket] pull request Jul 5, 2019
@paulmelnikow paulmelnikow added the blocker PRs and epics which block other work label Jul 5, 2019
@paulmelnikow paulmelnikow merged commit 9346548 into master Jul 5, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the refactor-bitbucket-pull-request branch July 5, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
blocker PRs and epics which block other work service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulmelnikow @shields-ci @calebcartwright @shields-cd