Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries.io dependency badges #570

Merged
merged 5 commits into from Aug 15, 2016
Merged

Conversation

malditogeek
Copy link
Contributor

This PR adds support for dependency badges on all the platforms supported on Libraries.io (https://libraries.io/about#matrix)

@malditogeek
Copy link
Contributor Author

cc @andrew

<td><code>https://img.shields.io/librariesio/github/phoenixframework/phoenix.svg</code></td>

</tr>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.html is generated, so this change won't survive a make website. I believe you want to put it in try.html.

(Also, you can omit empty lines. And match the first <tr> with a </tr>.)

@malditogeek
Copy link
Contributor Author

@espadrine thanks for reviewing it, just pushed those tweaks. The index.html I pushed was generated with make website

@espadrine
Copy link
Member

Perhaps Linux' sh is unlike OS X'. The index.html file that was generated on your computed produced an error. I would recommend removing it and squashing your commits. I will generate it myself.

@zbeekman
Copy link

@malditogeek ping

@WaveHack
Copy link

Any updates on this?

@espadrine espadrine merged commit 841059a into badges:master Aug 15, 2016
espadrine added a commit that referenced this pull request Aug 16, 2016
@@ -714,6 +714,14 @@ <h3 id="miscellaneous"> Longer Miscellaneous </h3>
<td><img src='/ansible/role/3078.svg' alt=''/></td>
<td><code>https://img.shields.io/ansible/role/3078.svg</code></td>
</tr>
<tr><th> Libraries.io for releases: </th>
<td><img src='https://img.shields.io/librariesio/release/hex/phoenix/1.0.3.svg' alt=''/></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be an https://img.shields.io at the start of the URL here, otherwise we cannot test the website.

I corrected it in f84b5cd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@espadrine
Copy link
Member

Thanks a lot! It's live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants