New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libraries.io dependency badges #570
Conversation
cc @andrew |
<td><code>https://img.shields.io/librariesio/github/phoenixframework/phoenix.svg</code></td> | ||
|
||
</tr> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.html is generated, so this change won't survive a make website
. I believe you want to put it in try.html.
(Also, you can omit empty lines. And match the first <tr>
with a </tr>
.)
@espadrine thanks for reviewing it, just pushed those tweaks. The index.html I pushed was generated with |
Perhaps Linux' |
@malditogeek ping |
Any updates on this? |
@@ -714,6 +714,14 @@ <h3 id="miscellaneous"> Longer Miscellaneous </h3> | |||
<td><img src='/ansible/role/3078.svg' alt=''/></td> | |||
<td><code>https://img.shields.io/ansible/role/3078.svg</code></td> | |||
</tr> | |||
<tr><th> Libraries.io for releases: </th> | |||
<td><img src='https://img.shields.io/librariesio/release/hex/phoenix/1.0.3.svg' alt=''/></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be an https://img.shields.io
at the start of the URL here, otherwise we cannot test the website.
I corrected it in f84b5cd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks a lot! It's live. |
This PR adds support for dependency badges on all the platforms supported on Libraries.io (https://libraries.io/about#matrix)