Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop .env support #5864

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Drop .env support #5864

merged 2 commits into from
Nov 23, 2020

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Nov 22, 2020

As discussed in #5773.

@PyvesB PyvesB added self-hosting Discussion, problems, features, and documentation related to self-hosting Shields core Server, BaseService, GitHub auth labels Nov 22, 2020
@shields-ci
Copy link

shields-ci commented Nov 22, 2020 •
edited

Messages
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 7896b1b

PyvesB
PyvesB commented Nov 22, 2020
View reviewed changes
package-lock.json
@@ -14096,7 +14096,8 @@
"dotenv": {
"version": "8.2.0",
"resolved": "https://registry.npmjs.org/dotenv/-/dotenv-8.2.0.tgz",
"integrity": "sha512-8sJ78ElpbDJBHNeBzUbUVLsqKdccaa/BXF1uPTw3GrvQTBgrQrtObr2mUrE38vzYd8cEv+m/JBfDLioYcfXoaw=="
"integrity": "sha512-8sJ78ElpbDJBHNeBzUbUVLsqKdccaa/BXF1uPTw3GrvQTBgrQrtObr2mUrE38vzYd8cEv+m/JBfDLioYcfXoaw==",
"dev": true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was disappointed to see we still had dev dependencies transitively depending on it.

calebcartwright
calebcartwright approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PyvesB
Copy link
Member Author

PyvesB commented Nov 23, 2020

(please don't merge this yet, I want to do the communication bit at the same time)

@PyvesB PyvesB merged commit c73b92f into badges:master Nov 23, 2020
@github-actions
Copy link
Contributor

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@chris48s chris48s mentioned this pull request Jan 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth self-hosting Discussion, problems, features, and documentation related to self-hosting Shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PyvesB @shields-ci @paulmelnikow @calebcartwright