Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Simple Icons Versioning #6161

Closed
wants to merge 1 commit into from
Closed

Update Simple Icons Versioning #6161

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2021

See: simple-icons/simple-icons@4.8.0...4.10.0

Shields is currently missing the 40+ icon updates added in just the past 10 days.

Either:

  • The dependabot automation to update this specific version should be made more frequent (e.g. match the release cron for Simple Icons; 00:00 on Sunday) This option would likely get me shot for suggesting it

or:

  • The version should be set to all compatible versions (i.e. up to 5.0.0, when the version would need to be reevaluated anyway). This options seems more reasonable to me

See: simple-icons/simple-icons@4.8.0...4.10.0

**Shields** is currently missing the 40+ icon updates added in just the past 10 days.

Either:
* The dependabot automation to update this specific version should be made more frequent (e.g. match the release cron for Simple Icons;  00:00 on Sunday)
or
* The version should be set to all compatible versions (i.e. up to 5.0.0, when the version would need to be reevaluated anyway)
@shields-ci
Copy link

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

Messages
📖 ✨ Thanks for your contribution to Shields, @yuri-norwood!

Generated by 🚫 dangerJS against ba3970f

@calebcartwright
Copy link
Member

hi @yuri-norwood and thanks for the PR! I'm going to have to close this unfortunately.

Our process for incorporating simple icons, and the subsequent deployment with the updated version, is described in detail here. The changes proposed here won't change the cadence at which we actually deploy, and would only make it less clear what version has actually been deployed.

I can appreciate folks' desire to get the latest and greatest simple icons updates, but we are always going to lag behind their latest somewhat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants