send custom user agent when using got #6256
Conversation
| @@ -3,6 +3,8 @@ | |||
| const got = require('got') | |||
| const { Inaccessible, InvalidResponse } = require('./errors') | |||
|
|
|||
| const userAgent = 'Shields.io/2003a' | |||
There was a problem hiding this comment.
I have no idea what this number means. I just copied it from
I decided to just duplicate this in got.js instead of importing it from legacy-request-handler as I think we can get rid of a lot of what is in there in the near future
There was a problem hiding this comment.
😆 I almost asked about this too but vaguely remembered it being a magical value of sorts
There was a problem hiding this comment.
CalVer! 😁
It means GHSA-6qx4-g993-2225 is patched. The intent was to make it possible for upstream services to block requests from unpatched self-hosted instances.
Now that we've got actual versions (thanks @chris48s!) if it's possible to get the actual version in there I think that'd be a nice refinement.
There was a problem hiding this comment.
That.. sort of makes sense for self-hosted installs (unless they track next/master), although we don't pin our own deploys to a version, by which I mean
we tag server-YYYY-MM-DD and deploy
we make some more commits and deploy those too
now the version we're running in production isn't server-YYYY-MM-DD - its a future version that doesn't correspond to any tag
I suppose Shields.io/server-YYY-MM-DD would at least mean server-YYY-MM-DD (or later)
There was a problem hiding this comment.
Sure. We could also use server-YYY-MM-DD for the Docker releases and includ something like server-YYY-MM-DD+dev for production.
Reading this thread makes me think we should include some extra stuff in the query string on request for the dynamic + endpoint badges, or when a user-specified URL is used, since it allows a service provider to differentiate between our official badge requests, and other requests which are being specified by the user.
There was a problem hiding this comment.
I've made an issue for this as I suspect we're not going to pick this up immediately and this conversation will disappear into the github ether. #6268
This reverts commit fd7eddc.
There was always going to be something that slipped through the cracks.
Closes #6251