Fixing incorrect JetBrains Plugin rating values for [JetBrainsRating]

services/jetbrains/jetbrains-rating.service.js

@@ -1,6 +1,7 @@
 import Joi from 'joi'
 import { starRating } from '../text-formatters.js'
 import { colorScale } from '../color-formatters.js'
+import { NotFound } from '../index.js'
 import JetbrainsBase from './jetbrains-base.js'
 
 const pluginRatingColor = colorScale([2, 3, 4])
@@ -22,6 +23,8 @@ const intelliJschema = Joi.object({
 }).required()
 
 const jetbrainsSchema = Joi.object({
+  votes: Joi.object().pattern(Joi.string(), Joi.number()).required(),
+  meanVotes: Joi.number().min(0).required(),
   meanRating: Joi.number().min(0).required(),
 }).required()
 
@@ -89,7 +92,23 @@ export default class JetbrainsRating extends JetbrainsBase {
         )}/rating`,
         errorMessages: { 400: 'not found' },
       })
-      rating = jetbrainsPluginData.meanRating
+
+      let voteSum = 0
+      let voteCount = 0
+      const votes = jetbrainsPluginData.votes
+      Object.entries(votes).forEach(([rating, votes]) => {
+        voteSum += parseInt(rating) * votes
+        voteCount += votes
+      })
+      const meanRating = jetbrainsPluginData.meanRating
+
+      if (voteCount === 0) {
+        throw new NotFound({ prettyMessage: 'No Plugin Ratings' })
+      }
+
+      // JetBrains Plugin Rating Formula from:
+      // https://plugins.jetbrains.com/docs/marketplace/plugins-rating.html
+      rating = (voteSum + 2 * meanRating) / (voteCount + 2)
     }
 
     return this.constructor.render({ rating, format })

services/jetbrains/jetbrains-rating.tester.js

@@ -57,9 +57,29 @@ t.create('rating number (numeric id)')
   .intercept(nock =>
     nock('https://plugins.jetbrains.com')
       .get('/api/plugins/11941/rating')
-      .reply(200, { meanRating: 4.4848 })
+      .reply(200, {
+        votes: {
+          4: 1,
+          5: 4,
+        },
+        meanVotes: 2,
+        meanRating: 4.15669,
+      })
   )
-  .expectBadge({ label: 'rating', message: '4.5/5' })
+  .expectBadge({ label: 'rating', message: '4.6/5' })
+
+t.create('rating number for "no vote" plugin (numeric id)')
+  .get('/rating/10998.json')
+  .intercept(nock =>
+    nock('https://plugins.jetbrains.com')
+      .get('/api/plugins/10998/rating')
+      .reply(200, {
+        votes: {},
+        meanVotes: 2,
+        meanRating: 4.15669,
+      })
+  )
+  .expectBadge({ label: 'rating', message: 'No Plugin Ratings' })
 
 t.create('rating number (string id)')
   .get('/rating/com.chriscarini.jetbrains.jetbrains-auto-power-saver.json')
@@ -91,7 +111,14 @@ t.create('rating stars (numeric id)')
   .intercept(nock =>
     nock('https://plugins.jetbrains.com')
       .get('/api/plugins/11941/rating')
-      .reply(200, { meanRating: 4.4848 })
+      .reply(200, {
+        votes: {
+          4: 1,
+          5: 4,
+        },
+        meanVotes: 2,
+        meanRating: 4.15669,
+      })
   )
   .expectBadge({ label: 'rating', message: '★★★★½' })