Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add [curseforge] downloads badge #7499

Closed

Conversation

Minecraftschurli
Copy link
Contributor

this PR adds the curseforge downloads badge requested in #4498

it includes:

  • auth helpers
  • documentation for the api token
  • the curseforge downloads badge

it sadly requires an api token to work for which the process for acquiring can be found here

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Jan 16, 2022
@shields-ci
Copy link

Warnings
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
Messages
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

📖 ✨ Thanks for your contribution to Shields, @Minecraftschurli!

Generated by 🚫 dangerJS against fa30605

@calebcartwright calebcartwright changed the title add curseforge downloads badge add [curseforge] downloads badge Jan 16, 2022
@calebcartwright
Copy link
Member

Thanks for the PR!

it sadly requires an api token to work for which the process for acquiring can be found here

Do you know how the authorization is scoped? I.e. will a request that authenticates with a valid token be allowed to pull data for any target, or does the token have to be explicitly authorized/scoped to the target in order to work?

@Minecraftschurli
Copy link
Contributor Author

it is an api token auth which is normally not scoped (in this case it is unscoped)

@Minecraftschurli
Copy link
Contributor Author

I have tested it with my api token and it worked (I didn't have to set any scopes)

@calebcartwright
Copy link
Member

The process for requesting an api key looks notably more involved and complicated than what we typically have to go through. What was your experience like?

@Minecraftschurli
Copy link
Contributor Author

I used the game developer api key which just requires a google account login

@calebcartwright
Copy link
Member

I used the game developer api key which just requires a google account login

Gotcha. We're going to need some time to talk this over amongst the core team, as well as likely needing to have a dialog with the Curseforge folks to determine if/when this might be viable to proceed.

@curio-sitas
Copy link

Any news ?

@starboyceleste
Copy link

?

@PyvesB
Copy link
Member

PyvesB commented Aug 13, 2023

This work was effectively merged via #9252. Thanks for the contribution and the patience!

@PyvesB PyvesB closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants