-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add [curseforge] downloads badge #7499
Conversation
|
Thanks for the PR!
Do you know how the authorization is scoped? I.e. will a request that authenticates with a valid token be allowed to pull data for any target, or does the token have to be explicitly authorized/scoped to the target in order to work? |
it is an api token auth which is normally not scoped (in this case it is unscoped) |
I have tested it with my api token and it worked (I didn't have to set any scopes) |
The process for requesting an api key looks notably more involved and complicated than what we typically have to go through. What was your experience like? |
I used the game developer api key which just requires a google account login |
Gotcha. We're going to need some time to talk this over amongst the core team, as well as likely needing to have a dialog with the Curseforge folks to determine if/when this might be viable to proceed. |
Any news ? |
? |
This work was effectively merged via #9252. Thanks for the contribution and the patience! |
this PR adds the curseforge downloads badge requested in #4498
it includes:
it sadly requires an api token to work for which the process for acquiring can be found here