Add [GitHubDiscussionsSearch] and GitHubRepoDiscussionsSearch service #9340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jNullj
changed the title
jNullj
force-pushed
the
feat/9213/github-discussions-custom-search
branch
from
6f38564
to
7006a63
Compare
jNullj
force-pushed
the
feat/9213/github-discussions-custom-search
branch
from
7006a63
to
c269340
Compare
|
Did a rebase to latest commit on master |
|
🚀 Updated review app: https://pr-9340-badges-shields.fly.dev |
chris48s
reviewed
Jul 7, 2023
chris48s
changed the title
This commit adds a GitHub Discussions custom search service in the github-discussions-custom-search.service.js file. It includes classes for global discussions search (GithubDiscussionsSearch) and repository-specific discussions search (GithubRepoDiscussionsSearch). Users can now search discussions with custom queries and retrieve the discussion count. Fixes badges#9213
Inform users of filters and query values for the free search.
Change examples from filter by author to `filter` by `answered-by` as this has higher change of being a more common use case.
jNullj
force-pushed
the
feat/9213/github-discussions-custom-search
branch
from
c269340
to
3fb024f
Compare
|
@chris48s about the name change, the tests for GitHubRepoDiscussionsSearch are wihthin the test files for GitHubDiscussionsSearch similar to how it is done with the issuesSearch. notice the error for the tester job at this line also did a rebase to latest commit at master |
chris48s
changed the title
|
🚀 Updated review app: https://pr-9340-badges-shields.fly.dev |
chris48s
reviewed
Jul 7, 2023
|
Yes. Sorry I hadn't clocked that This LGTM 👍 I will get it deployed over the weekend. Thanks |
chris48s
approved these changes
Jul 7, 2023
chris48s
added
service-badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GitHub Discussions custom search service
This commit adds a GitHub Discussions custom search service in the github-discussions-custom-search.service.js file. It includes classes for global discussions search (GithubDiscussionsSearch) and repository-specific discussions search (GithubRepoDiscussionsSearch). Users can now search discussions with custom queries and retrieve the discussion count.
Fixes #9213
TODO: