Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor css issues #81

Open
6 of 20 tasks
badlydrawnrob opened this issue Dec 24, 2023 · 5 comments
Open
6 of 20 tasks

Fix some minor css issues #81

badlydrawnrob opened this issue Dec 24, 2023 · 5 comments
Labels
enhancement so-so This is an intermediate edit

Comments

@badlydrawnrob
Copy link
Owner

badlydrawnrob commented Dec 24, 2023

Add useful CSS to this gist

Some minor changes with font-size and possibly additional styles for Markdown checkboxes. I'm using some edits of the original Print First CSS due to Verdana font being a bit too big at default --font-size.

Note: make sure rem is behaving properly (i.e. not inflating the font size with child elements)

Start here ...

Some very old CSS changes

code blocks

Some way to quickly spot a piece of code we're talking about (like the cloze deletion css)
It shouldn't be difficult to add (searching for a specific line of code once compiled is too slow)

Some rough tests here

Other things:

New functionality?

Back to the start ... priority changes

Some not-so-essential changes

  • We have <i> and <b> but there's also <mark>

Some rem tests

rem only calculates from the default font-size which is set in :root (the --font-size variables are set in print-first-css (or override in anki themes) @ style/modules/variables/typography.less. Tested in Codepen2 — more rem notes

Before After
image image

testing-rem-sizes-cascading
Screenshot 2024-01-03 at 22 34 11
Screenshot 2024-01-03 at 22 40 04

More examples of --font-size issues:

Screenshot 2023-12-24 at 22 10 46 Screenshot 2023-12-24 at 22 11 00

Footnotes

  1. The code is currently doing some (slightly odd) font reduction as Verdana was too big at the root font-size.

  2. There is the question whether :root is the correct element to set the base font-size, perhaps html element is more appropriate, but fuck it, it seems to work fine. According to this root is practically the same as html

@badlydrawnrob badlydrawnrob added enhancement easy This is an easy edit labels Dec 24, 2023
@badlydrawnrob badlydrawnrob pinned this issue Jan 3, 2024
@badlydrawnrob
Copy link
Owner Author

Screenshot 2024-01-14 at 19 27 43

@badlydrawnrob
Copy link
Owner Author

Screenshot 2024-01-17 at 17 22 05

@badlydrawnrob
Copy link
Owner Author

Screenshot 2024-01-20 at 21 18 49

@badlydrawnrob
Copy link
Owner Author

Screenshot 2024-01-20 at 21 42 24

@badlydrawnrob
Copy link
Owner Author

badlydrawnrob commented Jan 21, 2024

Inline code isn't standout enough!

Screenshot 2024-01-21 at 14 14 16

@badlydrawnrob badlydrawnrob added so-so This is an intermediate edit and removed easy This is an easy edit labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement so-so This is an intermediate edit
Projects
None yet
Development

No branches or pull requests

1 participant