Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix color passed in options did not set the progress bar color #18

Merged
merged 1 commit into from
May 13, 2022
Merged

Fix color passed in options did not set the progress bar color #18

merged 1 commit into from
May 13, 2022

Conversation

dimitri-bourreau
Copy link
Contributor

Goal of this PR

Fix the fact that we could not set the color for the progress bar.

What this PR does

Update one file: index.ts by setting initialStyle.backgroundColor to config.color instead of "currentColor".

Context

This PR follows #17.

Thanks again to @jviide! 🎉

jviide
jviide approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@jviide jviide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you 🎉

@jviide jviide merged commit 138328d into badrap:master May 13, 2022
@dimitri-bourreau dimitri-bourreau deleted the fix/set-bar-color branch May 14, 2022 08:23
@jviide
Copy link
Contributor

jviide commented May 14, 2022

This change has been released as v0.2.1 (because I botched the GitHub Actions workflow when trying to release v0.2.0 😅). Thanks one more 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviide jviide jviide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimitri-bourreau @jviide