Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center rounded line alignment for StepIndicatorVerticalView #77

Merged
merged 1 commit into from
May 19, 2021

Conversation

rcole34
Copy link
Contributor

@rcole34 rcole34 commented May 19, 2021

Description

This small change corrects the center-alignment of rounded lines in StepIndicatorVerticalView. Other vertical line types and all horizontal line types have not been tested and may also need a similar fix if they are also subtracting the full width of the line rather than half.

Before After
Screen Shot 2021-05-19 at 2 57 45 PM Screen Shot 2021-05-19 at 2 58 52 PM

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update

How Has This Been Tested

This has been manually tested for the vertical rounded line type. The code in question is only used for that type of line, so it should not break any other types.

Test Configuration

  • Xcode version: 12.4
  • Device/Simulator 11 Pro simulator
  • iOS version 14.4
  • MacOSX version 11.2.1

Checklist:

For checklist items not applicable, mention NA in front of it with some comment if applicable.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • Add comments to code particularly in hard-to-understand areas
  • My changes generate no new warnings
  • NA I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes before pushing the pull request

@badrinathvm badrinathvm self-requested a review May 19, 2021 22:41
@badrinathvm
Copy link
Owner

Thank you @rcole34 for the contribution and the code looks good for VerticalView also validated the horizontal one no changes are required for it as it is already midY ( https://github.com/badrinathvm/StepperView/blob/master/Sources/StepperView/Views/StepIndicatorHorizontalView.swift#L144 )

@badrinathvm badrinathvm merged commit 03893c4 into badrinathvm:master May 19, 2021
@badrinathvm badrinathvm mentioned this pull request May 19, 2021
10 tasks
@rcole34 rcole34 deleted the vertical_rounded_line_fix branch May 19, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants