Clean up when windows process stop (#807)

Co-authored-by: hanpengfei01 <hanpengfei01@baidu.com>
baetyl · Nov 21, 2023 · b0dd868 · b0dd868
1 parent e6e836d
commit b0dd868
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/ami/native/native.go b/ami/native/native.go
@@ -430,17 +430,16 @@ func (impl *nativeImpl) DeleteApp(ns string, app v1.AppInfo) error {
 				var childs *[]ami.ProcessInfo
 				if runtime.GOOS == "windows" {
 					status, err := svc.Status()
-					if err != nil {
-						return errors.Trace(err)
-					}
-					if status == service.StatusRunning {
-						pid, err := svc.GetPid()
-						if err != nil {
-							impl.log.Warn("failed to get svc pid", log.Error(err))
-						}
-						childs, err = getChildProcessInfo(pid)
-						if err != nil {
-							impl.log.Warn("failed to get child pid", log.Error(err))
+					if err == nil {
+						if status == service.StatusRunning {
+							pid, err := svc.GetPid()
+							if err != nil {
+								impl.log.Warn("failed to get svc pid", log.Error(err))
+							}
+							childs, err = getChildProcessInfo(pid)
+							if err != nil {
+								impl.log.Warn("failed to get child pid", log.Error(err))
+							}
 						}
 					}
 				}