Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double tokenisation #1

Closed
vandijkstef opened this issue Dec 19, 2019 · 3 comments · Fixed by #2
Closed

Double tokenisation #1

vandijkstef opened this issue Dec 19, 2019 · 3 comments · Fixed by #2

Comments

@vandijkstef
Copy link

Hey, awesome action, but most actions probably already use token. Currently using this Im seeing actions as my own user, not as github-bot. I've forked and renamed it into pattoken, which allows for token usage in other actions, and will perform those actions as the github bot.

Please review vandijkstef/use-private-action@v0.0.2

@bagbyte
Copy link
Owner

bagbyte commented Jan 17, 2020

Hi, sorry for the delay.
I'm not sure I got you 100% here. I saw in your code you add a reference to a new parameter (which is not declared in action.yml) called pattoken, but I don't see the difference with my code (unless this is a reserved/special parameter name?), because at the end it's just the name of the parameter, what really matters is the value you assign to it when using the action

@vandijkstef
Copy link
Author

A lot of actions use 'token' to authenticate actions, like placing comments.

Since this was also the 'key' of the token your action uses to authenticate into private repos, it was passed on, and other actions started to do things as the user that created the Private Access Token.

I wanted to have the other actions to act as 'Github bot', which has enough permissions to place comments on the current repo's PR's. Since we don't have our own bot account, and we really didn't want to use a real user.

@bagbyte
Copy link
Owner

bagbyte commented Jan 22, 2020

I've released a new version, thanks for the feedback

@bagbyte bagbyte closed this as completed May 12, 2020
@bagbyte bagbyte linked a pull request May 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants