Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CopyCertSubject() to check if CA cert is valid. #116

Closed
wants to merge 1 commit into from

Conversation

ldx
Copy link
Contributor

@ldx ldx commented Sep 3, 2014

SecCertificateCopyPublicKey() is not available on iPhone. Use
CopyCertSubject() instead to see if the certificate returned by
SecCertificateCreateWithData() is valid.

SecCertificateCopyPublicKey() is not available on iPhone. Use
CopyCertSubject() instead to see if the certificate returned by
SecCertificateCreateWithData() is valid.
@captain-caveman2k
Copy link
Contributor

Hi Vilmos,

Many thanks for your recent patches and your discussion with Nick and others on the curl-library hackers mailing list. As you seem to becoming more of a active/regular contributor could I please ask that you post you modifications as git patch files (either as attachments or git emails) to the mailing list rather than as pull requests.

Additionally, could I also ask that your commit messages follow our template commit message.

For more information about both of these points please see:

http://curl.haxx.se/dev/contribute.html

This will assist us in testing and pushing your contributions as well as allowing a wider audience access to them, being able to comment on them and assist in the development of them, especially as not everyone receives the automated pull request emails from GitHub.

Many thanks in advance

Kind Regards

Steve

@ldx
Copy link
Contributor Author

ldx commented Sep 3, 2014

Hey Steve,

sorry about that - I did not know about the guidelines. I'll send a patch to the list.

@captain-caveman2k
Copy link
Contributor

Hiya Vilmos,

Great - thank you.

Steve

@ldx
Copy link
Contributor Author

ldx commented Sep 4, 2014

Sent patch to list.

@ldx ldx closed this Sep 4, 2014
@ldx ldx deleted the seccert_iphone branch September 4, 2014 13:48
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants