Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for continuation if we're executing a CUSTOMREQUEST #487

Closed
wants to merge 3 commits into from

Conversation

ehlertjd
Copy link
Contributor

Closes #486

@captain-caveman2k
Copy link
Contributor

The fix seems simple enough.

Unfortunately I'm not near any of my Linux boxes at the moment so I was wondering do the Imap tests still run with this fix?

@bagder
Copy link
Member

bagder commented Oct 13, 2015

I was wondering do the Imap tests still run with this fix?

The travis-CI tests says all OK here, so I would say yes they do! =)

@ehlertjd
Copy link
Contributor Author

I can also verify that they passed on my test system:

uname -a

Linux build-test 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15
17:43:14 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

On Tue, Oct 13, 2015 at 2:32 PM, Daniel Stenberg notifications@github.com
wrote:

I was wondering do the Imap tests still run with this fix?

The travis-CI tests says all OK here, so I would say yes they do! =)


Reply to this email directly or view it on GitHub
#487 (comment).

@captain-caveman2k
Copy link
Contributor

@bagder Cool - as I've been away from the project for a bit I couldn't remember if Travis-CI ran the test suit or not :-/

@ehlertjd Are you able to generate a custom request test as well. Again I can't remember if I wrote one when we added custom request support :-(

@ehlertjd
Copy link
Contributor Author

I'll take a look to see what's out there and get back.

On Tue, Oct 13, 2015 at 2:39 PM, Steve Holme notifications@github.com
wrote:

@bagder https://github.com/bagder Cool - as I've been away from the
project for a but I couldn't remember if Travis-CI ran the test suit or not
:-/

@ehlertjd https://github.com/ehlertjd Are you able to generate a custom
request test as well. Again I can't remember if I wrote one when we added
custom request support :-(


Reply to this email directly or view it on GitHub
#487 (comment).

@ehlertjd
Copy link
Contributor Author

I added a test (#841) that demonstrates the issue (in prior branches) and that the issue is fixed here. I also verified that there are a 11 other CUSTOMREQUEST tests in the IMAP suite. PR is pending Travis-CI validation.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants