Merge pull request #3608 from devansh-webkul/inactive_child_product_i…

…sssue Fixed inactive child product shouldn't visible in grouped product #3575
bagisto · Aug 5, 2020 · 07a9d85 · 07a9d85
2 parents 8ad125a + 67ddf60
commit 07a9d85
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 28 deletions.
diff --git a/packages/Webkul/Shop/src/Resources/views/products/view/grouped-products.blade.php b/packages/Webkul/Shop/src/Resources/views/products/view/grouped-products.blade.php
@@ -10,22 +10,24 @@
                         <span>{{ __('shop::app.products.qty') }}</span>
                     </li>
                     @foreach ($product->grouped_products as $groupedProduct)
-                        <li>
-                            <span class="name">
-                                {{ $groupedProduct->associated_product->name }}
+                        @if($groupedProduct->associated_product->getTypeInstance()->isSaleable())
+                            <li>
+                                <span class="name">
+                                    {{ $groupedProduct->associated_product->name }}
 
-                                @include ('shop::products.price', ['product' => $groupedProduct->associated_product])
-                            </span>
+                                    @include ('shop::products.price', ['product' => $groupedProduct->associated_product])
+                                </span>
 
-                            <span class="qty">
-                                <quantity-changer
-                                    :control-name="'qty[{{$groupedProduct->associated_product_id}}]'"
-                                    :validations="'required|numeric|min_value:0'"
-                                    quantity="{{ $groupedProduct->qty }}"
-                                    min-quantity="0">
-                                </quantity-changer>
-                            </span>
-                        </li>
+                                <span class="qty">
+                                    <quantity-changer
+                                        :control-name="'qty[{{$groupedProduct->associated_product_id}}]'"
+                                        :validations="'required|numeric|min_value:0'"
+                                        quantity="{{ $groupedProduct->qty }}"
+                                        min-quantity="0">
+                                    </quantity-changer>
+                                </span>
+                            </li>
+                        @endif
                     @endforeach
                 </ul>
             </div>

diff --git a/packages/Webkul/Velocity/src/Resources/views/shop/products/view/grouped-products.blade.php b/packages/Webkul/Velocity/src/Resources/views/shop/products/view/grouped-products.blade.php
@@ -10,22 +10,24 @@
                         <span>{{ __('shop::app.products.qty') }}</span>
                     </li>
                     @foreach ($product->grouped_products as $groupedProduct)
-                        <li>
-                            <span class="name">
-                                {{ $groupedProduct->associated_product->name }}
+                        @if($groupedProduct->associated_product->getTypeInstance()->isSaleable())
+                            <li>
+                                <span class="name">
+                                    {{ $groupedProduct->associated_product->name }}
 
-                                @include ('shop::products.price', ['product' => $groupedProduct->associated_product])
-                            </span>
+                                    @include ('shop::products.price', ['product' => $groupedProduct->associated_product])
+                                </span>
 
-                            <span class="qty">
-                                <quantity-changer
-                                    :control-name="'qty[{{$groupedProduct->associated_product_id}}]'"
-                                    :validations="'required|numeric|min_value:0'"
-                                    quantity="{{ $groupedProduct->qty }}"
-                                    min-quantity="0">
-                                </quantity-changer>
-                            </span>
-                        </li>
+                                <span class="qty">
+                                    <quantity-changer
+                                        :control-name="'qty[{{$groupedProduct->associated_product_id}}]'"
+                                        :validations="'required|numeric|min_value:0'"
+                                        quantity="{{ $groupedProduct->qty }}"
+                                        min-quantity="0">
+                                    </quantity-changer>
+                                </span>
+                            </li>
+                        @endif
                     @endforeach
                 </ul>
             </div>