product's special price should not greater than price #2162
Comments
Merged
jitendra-webkul
added
Bug
|
AnnikaWolff
pushed a commit
to Haendlerbund/bagisto
that referenced
this issue
Jan 30, 2020
* velocity initial * sidebar updates * related products updates * Misc. updates * merged with prateek-base * updates * updates * initial commit * save velocity configuration * merged * search and misc. issues * product view, dynamic payment, shipping methods * mini-cart design updates * updates by prateek * shubhwebkul#3 merged * completed product view page * downloadable link css updated * css changed * home page updates * minor changes * minor updates * category filters * footer sticker css changed * shubhwebkul#5 merged * implemented layered navigation on category page * add missing api_token columns to database (table users and admins) * minor bugs * quantity changer implemented * price filter with input box * minor bugs * added option for featured and new products to be displayed * ensure the api_token is being generated on customer/admin creation * include with variable update * layered navigation layout fixed * disable price filter textbox * updates * revert updates * shubhwebkul#9 merged * WIP quick view * hot-categories, popular-categories, sidebar & other * minor changes * merged with velocity-1 * quick-view initial * resolved conflits * updates * minor updates * updates * theme bug fixes * introduce company_name column to customer_addresses * prepare functional test integration * introduce _support/FunctionalTester.php * add public/fonts to .gitignore * remove composer.lock from .gitignore * add factories necessary for testing customer and customer addresses * add optional vat_id to customer addresses * remove required html classes * updates * updates * introduce VatValidator.php * merged * display vat_id and company_name in edit.blade.php * display server side errors * move codeception progress reporter to require-dev * updates & initial responsive * remove address3 from customer_addresses fillable * split the 'name' column in the customer addresses into 'first_name' and 'last_name' - it is more common to save the data in this structure * some OrderRepository.php refactoring * add customer_vat_id column to order table * adjust factory * updates * minor changes * remove the splitting into first_name and last_name again - it can be desastrous to drop a column in a productive environment * removed redundant migration * various code style improvements * typo: s/formi/form * introduce vat faker * do not remove composer.lock .gitignore * use faker->vat in factory * typo fix, minor refactoring * updates * introduce some more factories and place them into the webkul core package to be available everywhere * updates * introduce company_name and vat_id also in shop admin backend * add vat_id to AddressDataGrid.php * WIP responsive * add validation rule * coupon applied * merged with prateek * merged with prateek * updates * remove velocity * remove velocity * velocity-configuration-added * resolved issues * remove factories (except necessary ones) from this pull request, as we deliver them as a separate PR * updates * drawer responsive * file changed * checkbox style fixed * checkbox style fixed * improve the way server side validation errors are being displayed * issue Product Page is not opening, Flash message is not showing properly in cart page. fixed * check if date_of_birth and oldpassword are set in request in profile edit action * updates * updates * isue fixed * updates * resolved issues * fixed drawer issues * use an locale from a country in europe so the vat id can be generated * remove codeception progress reporter to make compatibility with codeception 4 * enrich ci.yml with artifacts * add .gitignore to db-blade-compiler/views * responsive updates * add basic backend tests * add necessary packages/Webkul/Core/src/Database/Factories/LocaleFactory.php * load core factories * Fixed letter case issue in translation * Issue bagisto#2132 * Issue bagisto#2124 fixed * Issue bagisto#1779 fixed * update package.json * responsive updates * updates from bagisto * remove redundant use statement * remove redundant function * remove redundant factory registration * repair italian factory * Revert "Bagisto theme added" * query optimization and hide of expose model * fix trigger according to optional db-prefix * Issue bagisto#2146 fixed * Issue bagisto#2054 fixed * Issue bagisto#2147 * Issue bagisto#2149 * use correct vatId() formatter * remove |alpha_spaces validation from customer addresses city * Issue bagisto#2087 fixed * Removed commented code * add reporting for try-catch-sections * remove unused use statement * Issue bagisto#2155 * updated comment * test case changes * Issues bagisto#1189, bagisto#1148 fixed * Issue bagisto#2168 fixed * Issue bagisto#742 and bagisto#2165 * Issue bagisto#2167 fixed * Issue bagisto#2162 fixed * Issue bagisto#2173 fixed * Issue bagisto#2143 * Shipping discount issue fixed during refund creation * Issue bagisto#2177 fixed * Issue bagisto#2177 fixed * Issue bagisto#2183 fixed * Issue bagisto#2182 fixed * change log updated and Issue bagisto#2182 * change log updated and Issue bagisto#2182 * Issue bagisto#2185 * Issue bagisto#2186 * Issue bagisto#1988 fixed * Added translation seeder to DatabaseSeeder class * #Issue 2190 * Issue bagisto#2192 * Issue bagisto#2192 * Issue bagisto#2198 * Issue bagisto#2176, bagisto#2196 fixed * Issue bagisto#2185 Co-authored-by: Shubham Mehrotra <shubhammehrotra.symfony@webkul.com> Co-authored-by: Prateek Srivastava <48429511+prateek-webkul@users.noreply.github.com> Co-authored-by: aayush-webkul <53482391+aayush-webkul@users.noreply.github.com> Co-authored-by: Jitendra Singh <39991107+jitendra-webkul@users.noreply.github.com> Co-authored-by: rahulshukla-webkul <42834394+rahulshukla-webkul@users.noreply.github.com>
AnnikaWolff
added a commit
to Haendlerbund/bagisto
that referenced
this issue
Feb 5, 2020
* do not remove composer.lock .gitignore * use faker->vat in factory * typo fix, minor refactoring * updates * introduce some more factories and place them into the webkul core package to be available everywhere * resolve exception, rename function haveDownloadableItems * updates * introduce company_name and vat_id also in shop admin backend * add vat_id to AddressDataGrid.php * WIP responsive * add validation rule * coupon applied * merged with prateek * merged with prateek * updates * remove velocity * remove velocity * velocity-configuration-added * resolved issues * remove factories (except necessary ones) from this pull request, as we deliver them as a separate PR * updates * drawer responsive * file changed * checkbox style fixed * checkbox style fixed * improve the way server side validation errors are being displayed * issue Product Page is not opening, Flash message is not showing properly in cart page. fixed * check if date_of_birth and oldpassword are set in request in profile edit action * updates * updates * isue fixed * updates * resolved issues * fixed drawer issues * use an locale from a country in europe so the vat id can be generated * remove codeception progress reporter to make compatibility with codeception 4 * enrich ci.yml with artifacts * add .gitignore to db-blade-compiler/views * responsive updates * added ProductsIndexCest; added factories * add basic backend tests * add necessary packages/Webkul/Core/src/Database/Factories/LocaleFactory.php * load core factories * button 'update cart' will only be shown if corresponding products are in cart * Fixed letter case issue in translation * Issue bagisto#2132 * removed redundant use statement from ProductServiceProvider * Issue bagisto#2124 fixed * Issue bagisto#1779 fixed * update package.json * responsive updates * updates from bagisto * removed test and factory (did not work properly) * remove redundant use statement * remove redundant function * remove redundant factory registration * repair italian factory * Revert "Bagisto theme added" * query optimization and hide of expose model * bagisto velocity theme updates * fix trigger according to optional db-prefix * Issue bagisto#2146 fixed * Issue bagisto#2054 fixed * updates * Issue bagisto#2147 * Issue bagisto#2149 * directory structure updates * use correct vatId() formatter * remove |alpha_spaces validation from customer addresses city * Issue bagisto#2087 fixed * Removed commented code * view order page updates * add reporting for try-catch-sections * remove unused use statement * Issue bagisto#2155 * updated comment * test case changes * Issues bagisto#1189, bagisto#1148 fixed * Issue bagisto#2168 fixed * Issue bagisto#742 and bagisto#2165 * Issue bagisto#2167 fixed * Issue bagisto#2162 fixed * Issue bagisto#2173 fixed * Issue bagisto#2143 * responsive updates * Shipping discount issue fixed during refund creation * Issue bagisto#2177 fixed * Issue bagisto#2177 fixed * Issue bagisto#2183 fixed * Issue bagisto#2182 fixed * change log updated and Issue bagisto#2182 * change log updated and Issue bagisto#2182 * Issue bagisto#2185 * Issue bagisto#2186 * misc. bug fixes * add functional test for cart, fix tests with usage of * fix simple product in cartcest * fix wrong product state in haveVirtualProduct * Issue bagisto#1988 fixed * Added translation seeder to DatabaseSeeder class * #Issue 2190 * Issue bagisto#2192 * Issue bagisto#2192 * Issue bagisto#2198 * change annotation comment * Issue bagisto#2176, bagisto#2196 fixed * Issue bagisto#2185 * search in particular category * minor bug fixes * Issue bagisto#2192 * Issue bagisto#2204 * [Fixed: changed customer group code for newly created customer.] * merge with master * rtl initial * refactor functional AttributeCest, that was flickering sometimes * undo database renaming * add ability to provide company_name in address during checkout (optional) * add some factories into webkul core package to enhance testing potential * move factories into appropriate packages and remove redundant ones * some first_name and last_name input fields * add required validations * route issue resolved * Issue bagisto#2207 fixed * Issue bagisto#2203 fixed * Issue bagisto#2182 * Issue bagisto#2173 * merged conflicting factory manually * Issue bagisto#2202 fixed * category and category products through ajax * resolved issues * new and featured products from ajax * Fixed issue 2225 * Issue bagisto#2203 fixed * Issue bagisto#2182 fixed * Issue bagisto#2226 * Issue bagisto#2219 * product-card wishlist icon * [Added: review delete api route added.] * obey the default channel that has been set in config/app.php * Issue bagisto#2227 * Issue bagisto#1976 * Issue bagisto#2237 fixed * Changelog updated * Issue bagisto#2268 * Issue bagisto#2270 * Issue bagisto#2269 * revert tpye * Issue bagisto#2239 * correct database name in .env.testing, prevent AttributeCest from flickering * undo changes in .env.testing Co-authored-by: Shubham Mehrotra <shubhammehrotra.symfony@webkul.com> Co-authored-by: Prateek Srivastava <48429511+prateek-webkul@users.noreply.github.com> Co-authored-by: hb-monah <58027155+hb-monah@users.noreply.github.com> Co-authored-by: Jitendra Singh <39991107+jitendra-webkul@users.noreply.github.com> Co-authored-by: rahulshukla-webkul <42834394+rahulshukla-webkul@users.noreply.github.com> Co-authored-by: Florian Bosdorff <26360670+bosix@users.noreply.github.com> Co-authored-by: Vivek Sharma <viveksh047@webkul.com> Co-authored-by: Mohd Faiz <mohdfaiz.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Title
Special price should always be less than the normal price
Issue Description
When adding products that contain a price of $100 & a special price of $500 than in front end greater price value is showing instead of the minimum price if the product is under sale.
Preconditions
Please provide as detailed information about your environment as possible.
Steps to reproduce
Expected result
or
Actual result
The text was updated successfully, but these errors were encountered: