Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Velocity] Checkout: Shipping/Billing Address Name, email does not get updated #3053

Closed
chemisax opened this issue May 12, 2020 · 1 comment
Assignees
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.

Comments

@chemisax
Copy link
Contributor

Bug report

The order Name, Last Name and emails don't get updated with the address data, instead it uses the user data.

Issue Description

The shipping/billing name and email data is decided on this line:
https://github.com/bagisto/bagisto/blob/master/packages/Webkul/Velocity/src/Resources/views/shop/checkout/onepage.blade.php#L163-L165

It only changes if the user inputs a new address.
There is the case that the user name, shipping name and billing name are different, so the address should respect the value entered in the name, last name, email form.

Preconditions

Please provide as detailed information about your environment as possible.

1. master

Steps to reproduce

  1. Make an order with different shipping and billing contact details other than the user id data. (With pre saved data)

Expected result

  1. The user can save different names with different addresses, so the one page checkout should respect those names. The order is made with different names. It can be a problem because you can get to ship an order with an incorrect name.

Actual result

Respect the name, last_name, email information recorded on the saved address.

@jitendra-webkul jitendra-webkul added the Bug Something isn't working. label May 13, 2020
shubhwebkul pushed a commit to shubhwebkul/bagisto that referenced this issue May 18, 2020
@jitendra-webkul jitendra-webkul added the Done When enhancement is done. label May 18, 2020
jitendra-webkul added a commit that referenced this issue May 18, 2020
@vaishaliwebkul
Copy link

Hi @chemisax
Thanks for notifying the issue, it's resolved now

We are closing the issue, feel free to reopen anytime.

@devansh-webkul devansh-webkul added Bug Fixed When bug issue is fixed. and removed Done When enhancement is done. labels Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

5 participants