Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to send the products to wishlist from compare page if the product is not on the first position #5226

Closed
1 of 5 tasks
aayushbhatt18 opened this issue Oct 13, 2021 · 13 comments
Assignees
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Milestone

Comments

@aayushbhatt18
Copy link
Contributor

aayushbhatt18 commented Oct 13, 2021

Issue Description

On the compare page, if there are multiple products added for comparison.
Only the first product can be added to wishlist when you click on "heart" icon.
But when you try to do the same with other products, the products doesn't get added to cart.

wishlist issue

Bagisto Version

  • master branch
  • 1.3.3
  • 1.3.2
  • 1.3.1
  • 1.3.0

Steps To Reproduce

  1. Add multiple products to compare page for comparison.
  2. Try to add any product to wishlist from compare page which is not in the first position.

Actual Result

The products except for the first position are not getting added to wishlist.

Expected Result

All the products should get added to the wishlist.

@aayushbhatt18 aayushbhatt18 added Bug Something isn't working. Easy Hacktoberfest Bagisto Hacktoberfest Event. labels Oct 13, 2021
@devansh-webkul devansh-webkul added this to the 1.4.0 milestone Oct 13, 2021
@JunaidJaved248
Copy link
Contributor

@devansh-webkul Can i work on it?

@devansh-webkul
Copy link
Member

Hi @JunaidJaved248,

Yeah sure.

@JunaidJaved248
Copy link
Contributor

@devansh-webkul can i guide me, If want to made changes in any index file or component , which steps i need to flow?

@JunaidJaved248
Copy link
Contributor

I am asking this because during previous pull requests, i tried to make changes in UI like index or component files but changes not reflecting

@devansh-webkul
Copy link
Member

I already shared you here,
#5243 (comment)

You should be familiar with Vue JS and the development environment.

@devansh-webkul
Copy link
Member

Hi @JunaidJaved248,

Are you working on this?

@JunaidJaved248
Copy link
Contributor

Hi @devansh-webkul Yes, working,
I have debug the issue, But while implementing it, it doesn't affecting the change on Vue templates.
I commented above about the guidance about it, But You have mentioned that Flow the steps. I followed them for it but its not affecting the changes, Still trying implement changes

@devansh-webkul
Copy link
Member

Alright!

@devansh-webkul
Copy link
Member

@JunaidJaved248,

I am seeing, you are already working on another issue. Are you working on this?

@JunaidJaved248
Copy link
Contributor

JunaidJaved248 commented Oct 28, 2021

@JunaidJaved248,

I am seeing, you are already working on another issue. Are you working on this?

@devansh-webkul I am working on it on another branch, while working on it, I have viewed that issue, that's much understandable to me that's why I fixed that one yesterday.
About this issue, I did work on it, issue debugged & Solution also implemented but not reflecting on preview site. If anyone from your team help me out to reaching out the exact way to modify compare products vue component that will be good , I will fix that issue.
Thanks!!

@devansh-webkul
Copy link
Member

devansh-webkul commented Oct 28, 2021

You should be familiar with the Vue development environment. There are several topics available that you can check on the Bagisto forum.

@devansh-webkul
Copy link
Member

This is the component you need to modify,

No compilation is needed.

@JunaidJaved248
Copy link
Contributor

This is the component you need to modify,

No compilation is needed.

Okay Right!! @devansh-webkul

@devansh-webkul devansh-webkul added Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. and removed In Progress labels Nov 9, 2021
@devansh-webkul devansh-webkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Projects
None yet
Development

No branches or pull requests

3 participants