UI - Responsiveness Issue in category page (Velocity theme) Fixed

[JunaidJaved248]

Issue Reference

#5223

Description

I have Fix Filter Category UI - Responsiveness Issue in category page (Velocity theme) Fixed, I have Updated the velocity.css file.

How To Test This?

You can just pull the latest code. It will be applied

Documentation

My Pull Request just need to update velocity theme latest update, then changes will be applied on project.

No Need to change anything, just need to pull latest code from repo

[JunaidJaved248]

@aayushbhatt18 have you reviewed the PR?

[aayushbhatt18]

This issue is fixed and can be merged.

[devansh-webkul]

@JunaidJaved248

This is only compiled files where is the main code file.

[JunaidJaved248]

Main code file is in this path, bagisto/packages/webkul/Velocity/publishable/assets/css/velocity.css

…

On Mon, 18 Oct 2021, 11:00 AM Devansh ***@***.*** wrote: @JunaidJaved248 <https://github.com/JunaidJaved248> This is only compiled files where is the main code file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5243 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKC7JGHTU4H7RUOA6TYTRNLUHOZZFANCNFSM5GCQG5HA> .

[devansh-webkul]

This is a publishable path. You need to do the changes in the scss file then after compiling it will be placed here.

[JunaidJaved248]

@devansh-webkul Please share the path of that file, I will make changes in that file

[devansh-webkul]

Check here,
https://github.com/bagisto/bagisto/tree/master/packages%2FWebkul%2FVelocity%2Fsrc%2FResources%2Fassets%2Fsass

[JunaidJaved248]

Check here, https://github.com/bagisto/bagisto/tree/master/packages%2FWebkul%2FVelocity%2Fsrc%2FResources%2Fassets%2Fsass

So, https://github.com/bagisto/bagisto/blob/master/packages/Webkul/Velocity/src/Resources/assets/sass/app.scss in need to make changes in this file Right?

[devansh-webkul]

Yes, just explore and try it.

[JunaidJaved248]

@devansh-webkul Done

[devansh-webkul]

@JunaidJaved248,

I will provide you feedback by today evening.

[JunaidJaved248]

Okay thanks

…

On Tue, 19 Oct 2021, 8:34 AM Devansh ***@***.*** wrote: @JunaidJaved248 <https://github.com/JunaidJaved248>, I will provide you feedback by today evening. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5243 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKC7JGBRHG4EEIFQEBV252DUHTRK3ANCNFSM5GCQG5HA> .

[JunaidJaved248]

@devansh-webkul Please check now. Approve this PR then I will move forward for working on other issues.
Thanks!!

[ghermans]

@JunaidJaved248 please recompile the assets before we can approve your PR

[JunaidJaved248]

@ghermans I have already done with it. Just removed the unknow bracket that present in file.
Now, Its Done by my end. If something let my end , then Let me know
Thanks

[devansh-webkul]

HI @JunaidJaved248,

In the last commit,

• Your compilation files are missing. If you have compiled this, then you will also get the manifest file that is missing.

• However I tested without compilation the pages are looking very weird,

• Desktop Screen

  

• Mobile Screen

  

Expected Result

[JunaidJaved248]

@devansh-webkul @ghermans Its Done Now. Hope for the best now.
Please check it out

[devansh-webkul]

Hi @JunaidJaved248,

It's still not compiled, let me help you,

For Production

• Go to the packages/Webkul/Velocity path.
• Run npm run prod.
• If node_modules not installed then run this npm install && npm run prod.
• After compilation, publish your package and check all the changes on the frontend.

For Development

• Go to the packages/Webkul/Velocity path.
• Run npm run watch.
• If node_modules not installed then run this npm install && npm run watch.
• No need to compile as hot reloading automatically does for you.
• Once you are done with your development, then run npm run prod. This will compile your assets.
• And then push to the github.

[JunaidJaved248]

@devansh-webkul Okay Thanks!!

[JunaidJaved248]

@devansh-webkul Can you please check it now

[devansh-webkul]

Hi @JunaidJaved248,

I tested the category section in desktop white background is appearing. I am sharing both actual and expected results. Please have a look,

Actual Result

Expected Result

[JunaidJaved248]

@devansh-webkul Let me fix it!

[JunaidJaved248]

@devansh-webkul Its Fixed now!! Please check it now.
let me know if still change required
Thanks!!

[devansh-webkul]

Hi @JunaidJaved248,

In mobile view when I click on the filter the sidebar is down and detached from the side and top. I am sharing with you the actual and expected results (that looks in master).

Actual Result

Expected Result

[JunaidJaved248]

@devansh-webkul I just checked it from live demo of bagisto. It was already detached. It doesn't affect by my PR changes Its another issue.

Anyway, let me check it & will fix it

[devansh-webkul]

@JunaidJaved248,

Just try the category which doesn't have an image.

[devansh-webkul]

Alright, this is a different issue. I am approving this.

[JunaidJaved248]

@devansh-webkul Anyway, Found the issue, Just Debugging & Fixing it, open issue for this bug, I will fix it. Thanks

[devansh-webkul]

Just make sure when you raise new PR. Your master should be updated with the Bagisto.

[devansh-webkul]

And also please provide your twitter handler, our team will contact you there for the Bagisto swag and goodies.

[JunaidJaved248]

And also please provide your twitter handler, our team will contact you there for the Bagisto swag and goodies.

@devansh-webkul Here it is: https://twitter.com/junaidjaved248

[JunaidJaved248]

Just make sure when you raise new PR. Your master should be updated with the Bagisto.

Okay Sure!!

[saurav-webkul]

Hi @JunaidJaved248

Could you send us a message here: https://twitter.com/BagistoShop