Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The flash message should be according to the selected locale if the admin trying to create a Shipment. #6205

Closed
Sanjaybhattwebkul opened this issue Apr 1, 2022 · 1 comment
Closed

The flash message should be according to the selected locale if the admin trying to create a Shipment. #6205

Sanjaybhattwebkul opened this issue Apr 1, 2022 · 1 comment
Assignees
@prateek-webkul @Sanjaybhattwebkul
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.
Milestone
1.4.3

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Bagisto Version: Master

Steps To reproduce--

1. Log in as a customer.
2. Change the app locale in Arabic..
3. Create an order.
4. Login as an admin.
5. Try to create shipment for the same order.

Expected result: The flash message should be according to the selected locale if the admin trying to create a Shipment.

Actual result: The flash message is showing according to the customer's locale when the admin trying to create a Shipment. Please find the screenshot Here.
@Sanjaybhattwebkul Sanjaybhattwebkul added the Bug Something isn't working. label Apr 1, 2022
@jitendra-webkul jitendra-webkul added this to the 1.4.3 milestone Apr 1, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added Optimization Optimization needed. Bug Fixed When bug issue is fixed. Bug Something isn't working. and removed Bug Something isn't working. Optimization Optimization needed. Bug Fixed When bug issue is fixed. labels Apr 4, 2022
Anmol-Chauhan pushed a commit to Anmol-Chauhan/bagisto that referenced this issue Apr 4, 2022
issue bagisto#6205
51d6a98
jitendra-webkul added a commit that referenced this issue Apr 5, 2022
@jitendra-webkul
Merge pull request #6225 from Anmol-Chauhan/flash-translation-issue
db7e051 
issue #6205
@jitendra-webkul jitendra-webkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Apr 5, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul self-assigned this Apr 5, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul removed the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Apr 5, 2022
@Sanjaybhattwebkul
Copy link
Contributor Author

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

@Sanjaybhattwebkul Sanjaybhattwebkul added the Bug Fixed When bug issue is fixed. label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prateek-webkul prateek-webkul

@Sanjaybhattwebkul Sanjaybhattwebkul

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Milestone
1.4.3
Development

No branches or pull requests
3 participants
@jitendra-webkul @prateek-webkul @Sanjaybhattwebkul