Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The currency icon is overriding on the currency dropdown when the app locale is Arabic. #6279

Closed
Sanjaybhattwebkul opened this issue Apr 11, 2022 · 1 comment
Closed

The currency icon is overriding on the currency dropdown when the app locale is Arabic. #6279

Sanjaybhattwebkul opened this issue Apr 11, 2022 · 1 comment
Assignees
@Sanjaybhattwebkul
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. UI UI package related issue.
Milestone
1.4.3

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Bagisto Version: Master

Steps To reproduce--

1. Login as a customer
2. Change the app locale in Arabic.
3. Try to change the app currency.

Actual result: The currency icon is overriding on the currency dropdown when the app locale is Arabic. Please find the screenshot Here

Expected result: The currency icon should not override the currency dropdown
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Something isn't working. UI UI package related issue. labels Apr 11, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added this to the 1.4.3 milestone Apr 11, 2022
Sanjaybhattwebkul pushed a commit to Sanjaybhattwebkul/bagisto that referenced this issue Apr 11, 2022
Issue bagisto#6279 fixed
bbdac0a
@Sanjaybhattwebkul Sanjaybhattwebkul mentioned this issue Apr 11, 2022
Merged
@Sanjaybhattwebkul Sanjaybhattwebkul added Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. and removed In Progress labels Apr 11, 2022
jitendra-webkul added a commit that referenced this issue Apr 11, 2022
@jitendra-webkul
Merge pull request #6281 from Sanjaybhattwebkul/currency-icon
3c1f968 
Issue #6279 fixed
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Apr 11, 2022
@Sanjaybhattwebkul
Copy link
Contributor Author

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sanjaybhattwebkul Sanjaybhattwebkul

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. UI UI package related issue.
Projects
None yet
Milestone
1.4.3
Development

No branches or pull requests
2 participants
@Anmol-Chauhan @Sanjaybhattwebkul