Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The quantity field should not take a negative value if the admin is trying to edit the quantity #6334

Closed
Sanjaybhattwebkul opened this issue Apr 21, 2022 · 1 comment
Closed

The quantity field should not take a negative value if the admin is trying to edit the quantity #6334

Sanjaybhattwebkul opened this issue Apr 21, 2022 · 1 comment
Assignees
@devansh-webkul
Labels
Admin Admin package related issues. Bug Fixed When bug issue is fixed. Bug Something isn't working.
Milestone
1.4.4

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Sanjaybhattwebkul commented Apr 21, 2022 •
edited

Bagisto Version: Master

Steps To reproduce--

1. Log in as an admin.
2. Click on products inside the catalog.
3. Click on quantity of any product.
4. Enter quantity value in minus.

Expected result: The quantity field should not take a negative value if the admin is trying to edit the quantity.

Actual result: The admin is able to add product quantity in minus. Please find the screenshot Here
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Something isn't working. Admin Admin package related issues. labels Apr 21, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added this to the 1.4.4 milestone Apr 21, 2022
@devansh-webkul devansh-webkul mentioned this issue May 9, 2022
Merged
@Sanjaybhattwebkul Sanjaybhattwebkul changed the title The quantity field should not take a negative value if the admin is trying to edit the quantity. Please find the screenshot Here The quantity field should not take a negative value if the admin is trying to edit the quantity May 9, 2022
@devansh-webkul devansh-webkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label May 9, 2022
@devansh-webkul devansh-webkul self-assigned this May 9, 2022
jitendra-webkul added a commit that referenced this issue May 9, 2022
@jitendra-webkul
Merge pull request #6411 from devansh-webkul/validation-message-added
b65edd9 
Validations Message Added #6334
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels May 9, 2022
@Sanjaybhattwebkul
Copy link
Contributor Author

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devansh-webkul devansh-webkul

Labels
Admin Admin package related issues. Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
2 participants
@devansh-webkul @Sanjaybhattwebkul