Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should not be any warning message for the default empty option if the admin is trying to create/edit any attribute. #6461

Closed
Sanjaybhattwebkul opened this issue Jun 1, 2022 · 1 comment
Closed

There should not be any warning message for the default empty option if the admin is trying to create/edit any attribute. #6461

Sanjaybhattwebkul opened this issue Jun 1, 2022 · 1 comment
Assignees
@Sanjaybhattwebkul @akathuria289
Labels
Admin Admin package related issues. Bug Fixed When bug issue is fixed. Bug Something isn't working.
Milestone
1.4.4

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Bagisto Version: Master

Steps To reproduce--

1. Log in as an admin.
2. Click on attributes inside the catalog section
3. Create a select type attribute.
4. Create a default empty option for the attribute.
5. Now try to edit the same attributes.

Expected result: There should not be any warning message for the default empty option if the admin is trying to edit any attribute.

Actual result: It is showing a warning message for the default empty option if the admin is trying to edit any attribute.Please find the screenshot Here
@Sanjaybhattwebkul Sanjaybhattwebkul added the Bug Something isn't working. label Jun 1, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul changed the title There should not be any warning message for the default empty option if the admin is trying to edit any attribute. There should not be any warning message for the default empty option if the admin is trying to create/edit any attribute. Jun 3, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added the Critical Something critical. Need immediate access. label Jun 3, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added this to the 1.4.4 milestone Jun 3, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul self-assigned this Jul 14, 2022
@devansh-webkul devansh-webkul removed In Progress Critical Something critical. Need immediate access. labels Jul 25, 2022
@devansh-webkul devansh-webkul added the Discussion When need discussion on some execution. label Jul 25, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added Admin Admin package related issues. and removed Discussion When need discussion on some execution. labels Aug 25, 2022
@akathuria289 akathuria289 mentioned this issue Aug 25, 2022
Merged
@Sanjaybhattwebkul Sanjaybhattwebkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Aug 25, 2022
jitendra-webkul added a commit that referenced this issue Aug 29, 2022
@jitendra-webkul
Merge pull request #6659 from akathuria289/issue_6461
555fd43 
Fixed issue #6461
@Sanjaybhattwebkul
Copy link
Contributor Author

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sanjaybhattwebkul Sanjaybhattwebkul

@akathuria289 akathuria289

Labels
Admin Admin package related issues. Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
4 participants
@papnoisanjeev @devansh-webkul @Sanjaybhattwebkul @akathuria289