Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should be a mouse-hover effect for the admin submenu in the dark theme. #6744

Closed
Sanjaybhattwebkul opened this issue Sep 23, 2022 · 1 comment · Fixed by #6754
Closed

There should be a mouse-hover effect for the admin submenu in the dark theme. #6744

Sanjaybhattwebkul opened this issue Sep 23, 2022 · 1 comment · Fixed by #6754
Assignees
@vivek-webkul
Labels
Admin Admin package related issues. Done When enhancement is done. Enhancement Recommending to make some changes in already build feature or flow. UI UI package related issue.
Milestone
1.5.0

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Sanjaybhattwebkul commented Sep 23, 2022 •
edited

Bagisto Version: Master

Steps To reproduce--

1. Log in as an admin in the dark theme
2. Mouse over and menu and submenu in the sidebar.

Expected result: There should be a mouse-over effect for the admin submenu in the dark theme.

Actual result: There is no mouse-over effect for submenus in the admin panel. Please find the screenshot Here
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Something isn't working. Admin Admin package related issues. UI UI package related issue. labels Sep 23, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul changed the title In the admin panel the mark as read and status icon is missing for notifications if locale in Arabic. There should be a mouse-over effect for the admin submenu in the dark theme. Sep 23, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added Enhancement Recommending to make some changes in already build feature or flow. and removed Bug Something isn't working. labels Sep 23, 2022
@kb-s
Copy link

kb-s commented Sep 24, 2022

hey @Sanjaybhattwebkul, I guess It should be mouse-hover effect if I'm not wrong!

@vivek-webkul vivek-webkul self-assigned this Sep 26, 2022
vivek-webkul added a commit to vivek-webkul/bagisto that referenced this issue Sep 26, 2022
@vivek-webkul
[Fixed: bagisto#6744]
26b13ee
@vivek-webkul vivek-webkul mentioned this issue Sep 26, 2022
Merged
@vivek-webkul vivek-webkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Sep 26, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul changed the title There should be a mouse-over effect for the admin submenu in the dark theme. There should be a mouse-hover effect for the admin submenu in the dark theme. Sep 26, 2022
jitendra-webkul added a commit that referenced this issue Sep 28, 2022
@jitendra-webkul
Merge pull request #6754 from vivek-webkul/patch-55
dfff278 
[Fixed: #6744]
@devansh-webkul devansh-webkul added Done When enhancement is done. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Apr 10, 2023
@shivendra-webkul shivendra-webkul added this to the 1.5.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vivek-webkul vivek-webkul

Labels
Admin Admin package related issues. Done When enhancement is done. Enhancement Recommending to make some changes in already build feature or flow. UI UI package related issue.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

[Fixed: #6744] vivek-webkul/bagisto
5 participants
@vivek-webkul @kb-s @devansh-webkul @Sanjaybhattwebkul @shivendra-webkul