Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should not be any warning if the admin is creating the catalog rule with the product's name. #6755

Closed
Sanjaybhattwebkul opened this issue Sep 26, 2022 · 1 comment · Fixed by #6928
Closed

There should not be any warning if the admin is creating the catalog rule with the product's name. #6755

Sanjaybhattwebkul opened this issue Sep 26, 2022 · 1 comment · Fixed by #6928
Assignees
@vivek-webkul
Labels
Admin Admin package related issues. Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Milestone
1.5.0

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Bagisto Version: Master

Steps To reproduce--

1. Log in as an admin.
2. Click on catalog rules inside the promotions.
3. Create a new catalog rule.
4. Select the Name from the condition dropdown.

Expected result: There should not be any warning if the admin is creating the catalog rule with the product's name.

Actual result: There is a warning message when the admin is creating the catalog rule with the product's name Please find the screenshot Here
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Something isn't working. Admin Admin package related issues. Hacktoberfest Bagisto Hacktoberfest Event. labels Sep 26, 2022
@JunaidJaved248
Copy link
Contributor

@Sanjaybhattwebkul I want to work on this issue also. Assign it to me.
I want to clarify one thing that when user select name is equal to then no warning should be shown Right? As you mentioned in screenshot..

@Sanjaybhattwebkul Sanjaybhattwebkul added this to the 2.0.0 milestone Oct 10, 2022
@vivek-webkul vivek-webkul self-assigned this Oct 14, 2022
vivek-webkul added a commit to vivek-webkul/bagisto that referenced this issue Oct 14, 2022
@vivek-webkul
[Fixed: bagisto#6755]
d49bfe8
@vivek-webkul vivek-webkul mentioned this issue Oct 14, 2022
Merged
@vivek-webkul vivek-webkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Oct 14, 2022
jitendra-webkul added a commit that referenced this issue Oct 17, 2022
@jitendra-webkul
Merge pull request #6928 from vivek-webkul/patch-62
801bf8f 
[Fixed: #6755]
@devansh-webkul devansh-webkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vivek-webkul vivek-webkul

Labels
Admin Admin package related issues. Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

[Fixed: #6755] vivek-webkul/bagisto
4 participants
@vivek-webkul @JunaidJaved248 @devansh-webkul @Sanjaybhattwebkul