Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should be a proper space between the cross and wishlist icon on the compare product's page. #6793

Closed
Sanjaybhattwebkul opened this issue Oct 3, 2022 · 3 comments
Closed

There should be a proper space between the cross and wishlist icon on the compare product's page. #6793

Sanjaybhattwebkul opened this issue Oct 3, 2022 · 3 comments
Assignees
@papnoisanjeev
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event. UI UI package related issue.
Milestone
1.5.0

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Bagisto Version: Master

Steps To reproduce--

1. Log in as a customer
2. Add any product to the compare.
3. Click on compare icon in the top right corner.

Expected result: There should be a proper space between the cross and wishlist icon on the compare product's page.

Actual result: The space between the cross and wishlist icon is not managed on the compare product's page. Please find the screenshot Here
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Something isn't working. UI UI package related issue. Hacktoberfest Bagisto Hacktoberfest Event. labels Oct 3, 2022
@imanpalsingh
Copy link

Hey can I pick this up?

papnoisanjeev added a commit to papnoisanjeev/bagisto that referenced this issue Oct 3, 2022
@papnoisanjeev
wishlist icon spacing issue on compare product's page bagisto#6793
81a99e4
@papnoisanjeev papnoisanjeev mentioned this issue Oct 3, 2022
Merged
@papnoisanjeev papnoisanjeev added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Oct 3, 2022
@papnoisanjeev papnoisanjeev self-assigned this Oct 3, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added this to the 2.0.0 milestone Oct 10, 2022
jitendra-webkul added a commit that referenced this issue Oct 11, 2022
@jitendra-webkul
Merge pull request #6795 from papnoisanjeev/compare-products-wishlist…
4b0be05 
…-icon-spaching-issue

wish-list icon spacing issue on compare product's page #6793
@Sanjaybhattwebkul Sanjaybhattwebkul added In Progress and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Oct 18, 2022
@Sanjaybhattwebkul
Copy link
Contributor Author

@papnoisanjeev
Please fix this issue for the Dutch locale also, this issue is not fox for the Dutch locale please find the screenshot Here

papnoisanjeev added a commit to papnoisanjeev/bagisto that referenced this issue Oct 19, 2022
@papnoisanjeev
[Fixed] bagisto#6793
8fa57ca
@papnoisanjeev papnoisanjeev mentioned this issue Oct 19, 2022
Merged
jitendra-webkul added a commit that referenced this issue Oct 19, 2022
@jitendra-webkul
Merge pull request #6969 from papnoisanjeev/spacing-issue-wishlist-an…
df1f4bb 
…d-button

[Fixed Issue] #6793
@Sanjaybhattwebkul
Copy link
Contributor Author

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Fixed When bug issue is fixed. and removed In Progress labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@papnoisanjeev papnoisanjeev

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event. UI UI package related issue.
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
3 participants
@papnoisanjeev @imanpalsingh @Sanjaybhattwebkul