Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation issue on footer section in default there, #6797

Closed
Sanjaybhattwebkul opened this issue Oct 3, 2022 · 2 comments
Closed

Translation issue on footer section in default there, #6797

Sanjaybhattwebkul opened this issue Oct 3, 2022 · 2 comments
Assignees
@papnoisanjeev
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Milestone
1.5.0

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Bagisto Version: Master

Steps To reproduce--

1. Visit the shop in the default theme.
2. Change app locale to Arabic.
3. Go to the footer section.
4. View the categories.

Expected result: Should not be any translation issue on footer section in default there,

Actual result: There is a translation issue on footer section in default there, Please find the screenshot Here
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event. labels Oct 3, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul self-assigned this Oct 3, 2022
@shubh-mehrotra shubh-mehrotra mentioned this issue Oct 3, 2022
Closed
shubh-mehrotra added a commit to shubh-mehrotra/bagisto that referenced this issue Oct 3, 2022
@shubh-mehrotra
Issue bagisto#6797 fixed
fbe2542
@shubh-mehrotra shubh-mehrotra mentioned this issue Oct 3, 2022
Merged
@Sanjaybhattwebkul Sanjaybhattwebkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Oct 4, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul removed their assignment Oct 4, 2022
jitendra-webkul added a commit that referenced this issue Oct 6, 2022
@jitendra-webkul
Merge pull request #6803 from shubh-mehrotra/issue-6797
4b6dcb2 
Issue #6797 fixed
@Sanjaybhattwebkul Sanjaybhattwebkul added this to the 2.0.0 milestone Oct 10, 2022
@Sanjaybhattwebkul
Copy link
Contributor Author

@papnoisanjeev
The footer content is not visible in default theme, Please find the screenshot Here

@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Oct 20, 2022
@Sanjaybhattwebkul
Copy link
Contributor Author

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@papnoisanjeev papnoisanjeev

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@papnoisanjeev @Sanjaybhattwebkul