Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guest welcome message translation missing in mobile view. #6908

Closed
ashishkumar-webkul opened this issue Oct 13, 2022 · 1 comment
Closed

Guest welcome message translation missing in mobile view. #6908

ashishkumar-webkul opened this issue Oct 13, 2022 · 1 comment
Assignees
@ashishkumar-webkul
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Milestone
1.5.0

Comments

@ashishkumar-webkul
Copy link
Collaborator

ashishkumar-webkul commented Oct 13, 2022 •
edited by Sanjaybhattwebkul

Issue Description

In mobile view when we check the Welcome guest, where we can see the Sign In and Sign Up details, there we can see the Guest Translation is missing for some languages like Hindi, Arabic etc.

Bagisto Version

MASTER

Steps To Reproduce

1. Inspect the details of a storefront in mobile view -> Check the sidebar for Welcome Guest.
2. Change the Locale Translation and there we will be able to see this issue.

Actual Result:

The translation is not correct for guest users in mobile view, please find the below screenshot.

hindiss

Image

Guest Translation missing

Expected Result

Please fix the translation issue related to the mobile view.
@Sanjaybhattwebkul Sanjaybhattwebkul changed the title Guest login translation missing in mobile view. Guest welcome message translation missing in mobile view. Oct 13, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event. labels Oct 13, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added this to the 2.0.0 milestone Oct 13, 2022
@vivek-webkul vivek-webkul self-assigned this Oct 13, 2022
ashishkumar-webkul added a commit to ashishkumar-webkul/bagisto that referenced this issue Oct 13, 2022
@ashishkumar-webkul
Issue bagisto#6908 fixed
dd3dbe6
@ashishkumar-webkul ashishkumar-webkul mentioned this issue Oct 13, 2022
Merged
@Sanjaybhattwebkul Sanjaybhattwebkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Oct 13, 2022
jitendra-webkul added a commit that referenced this issue Oct 14, 2022
@jitendra-webkul
Merge pull request #6919 from ashishkumar-webkul/greeting-guest-trans…
e848478 
…-issue

Issue #6908 fixed
@Sanjaybhattwebkul
Copy link
Contributor

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashishkumar-webkul ashishkumar-webkul

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
3 participants
@vivek-webkul @Sanjaybhattwebkul @ashishkumar-webkul