Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Arabic Translation, RTL view, table content should also be in RTL. #7105

Closed
1 task done
ashishkumar-webkul opened this issue Nov 16, 2022 · 1 comment
Closed
1 task done

In Arabic Translation, RTL view, table content should also be in RTL. #7105

ashishkumar-webkul opened this issue Nov 16, 2022 · 1 comment
Assignees
@papnoisanjeev
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Good First Issue Good for newcomers.
Milestone
1.5.0

Comments

@ashishkumar-webkul
Copy link
Collaborator

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

MASTER

Issue Description

When we check the Arabic Translation and there we can see that the table content, there we can still see the details in the LTR view.
It should also be seen in RTL.

Preconditions

Bagisto should be installed and all the necessary details should be added for the table content.

Steps to reproduce

  1. Go to Store Front -> Log in as a customer -> Check the orders page.
  2. Now Change the locale to Arabic in RTL.
  3. Now we can see the table content is still in LTR.

Expected Result

In RTL view the table content should also shift to RTL.

Actual Result

Please check the screenshot for better understanding of the issue.

Screenshots

RTL for the table

Additional context

No response
@ashishkumar-webkul ashishkumar-webkul added the Bug Something isn't working. label Nov 16, 2022
@papnoisanjeev papnoisanjeev self-assigned this Nov 18, 2022
papnoisanjeev added a commit to papnoisanjeev/bagisto that referenced this issue Nov 18, 2022
@papnoisanjeev
table content issue for RTL view bagisto#7105
c50bd94
@papnoisanjeev papnoisanjeev mentioned this issue Nov 18, 2022
Merged
@Sanjaybhattwebkul Sanjaybhattwebkul added the Good First Issue Good for newcomers. label Nov 18, 2022
@papnoisanjeev papnoisanjeev added Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. and removed In Progress labels Nov 21, 2022
jitendra-webkul added a commit that referenced this issue Nov 22, 2022
@jitendra-webkul
Merge pull request #7112 from papnoisanjeev/rtl-table-content-alignme…
254d7e8 
…nt-issue

Table content issue for RTL view customer panel #7105
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Nov 22, 2022
@Sanjaybhattwebkul
Copy link
Contributor

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

@shivendra-webkul shivendra-webkul added this to the 1.5.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@papnoisanjeev papnoisanjeev

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Good First Issue Good for newcomers.
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
4 participants
@papnoisanjeev @Sanjaybhattwebkul @ashishkumar-webkul @shivendra-webkul