Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create/Edit category, product mode is set to product only, the description is still required. #8426

Closed
1 task done
AmooAti opened this issue Sep 19, 2023 · 2 comments
Closed
1 task done

Create/Edit category, product mode is set to product only, the description is still required. #8426

AmooAti opened this issue Sep 19, 2023 · 2 comments
Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working.

Comments

@AmooAti
Copy link
Contributor

AmooAti commented Sep 19, 2023 •
edited

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

master

Issue Description

Hi,
Fantastic work on the fresh design!
While creating a category, the description is still required when the product mode is set to product only.

Preconditions

  1. Admin must be logged in.

Steps to reproduce

  1. Go to category grid.
  2. Click on Create button to create a new category.
  3. From the Settings section in right column, change Display Mode to Products Only

Expected Result

The product description field should no longer be required.

Actual Result

The product description field is still required.

Screenshots

Screenshot from 2023-09-19 13-21-29
@AmooAti AmooAti added the Bug Something isn't working. label Sep 19, 2023
@Amitk-webkul
Copy link
Collaborator

@AmooAti Thank you for the update.

@Amitk-webkul Amitk-webkul added the 2.x 2.x Versions label Sep 19, 2023
suraj-webkul added a commit to suraj-webkul/bagisto that referenced this issue Sep 19, 2023
@suraj-webkul
Issue bagisto#8426 fixed
5b6249d
@suraj-webkul suraj-webkul mentioned this issue Sep 19, 2023
Merged
@suraj-webkul suraj-webkul added the Bug Fixed When bug issue is fixed. label Sep 20, 2023
jitendra-webkul added a commit that referenced this issue Sep 20, 2023
@jitendra-webkul
Merge pull request #8438 from suraj-webkul/category-issue
58099e1 
Issue #8426 fixed
@Amitk-webkul
Copy link
Collaborator

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AmooAti @Amitk-webkul @suraj-webkul