Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While adding a slider image, image fields are required still I'm able to add a slider without an image. #8445

Closed
1 task done
Amitk-webkul opened this issue Sep 20, 2023 · 1 comment
Closed
1 task done

While adding a slider image, image fields are required still I'm able to add a slider without an image. #8445

Amitk-webkul opened this issue Sep 20, 2023 · 1 comment
Assignees
@amit-webkul
Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working.

Comments

@Amitk-webkul
Copy link
Collaborator

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

master

Issue Description

While adding a slider image, image fields are required still I'm able to add a slider without an image.

Preconditions

  1. Admin should be logged in.
  2. Admin needs to create a slider.

Steps to reproduce

  1. Go to 'Admin panel'
  2. Click on 'edit image carousel' inside the settings\themes
  3. Click on the Add slider
  4. Add a link and click on the save button.
  5. save the added image.
  6. See the error

Expected Result

It should show the image fields required message while adding a slider.

Actual Result

It is saving without an image. Here

Screenshots

No response

Additional context

No response
@Amitk-webkul Amitk-webkul added Bug Something isn't working. 2.x 2.x Versions labels Sep 20, 2023
@shivendra-webkul shivendra-webkul self-assigned this Sep 20, 2023
amit-webkul added a commit to amit-webkul/bagisto that referenced this issue Sep 25, 2023
@amit-webkul
Fixed Issue bagisto#8445
3fff8cf
@amit-webkul amit-webkul mentioned this issue Sep 25, 2023
Merged
@amit-webkul amit-webkul added the Bug Fixed When bug issue is fixed. label Sep 25, 2023
jitendra-webkul added a commit that referenced this issue Sep 25, 2023
@jitendra-webkul
Merge pull request #8512 from amit-webkul/lang_bn
f0e99d7 
Fixed Issue #8445
@Amitk-webkul
Copy link
Collaborator Author

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amit-webkul amit-webkul

Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Amitk-webkul @amit-webkul @shivendra-webkul