Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant images should be visible in the image view container on the product view page on Shop. #8528

Closed
1 task done
Amitk-webkul opened this issue Sep 25, 2023 · 1 comment
Closed
1 task done

Variant images should be visible in the image view container on the product view page on Shop. #8528

Amitk-webkul opened this issue Sep 25, 2023 · 1 comment
Assignees
@amit-webkul
Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.

Comments

@Amitk-webkul
Copy link
Collaborator

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

master

Issue Description

Variant images should be visible in the image view container on the product view page on Shop.

Preconditions

  1. Admin should be logged in.
  2. Admin should have at least one configurable product.
  3. Images should be added to that product.

Steps to reproduce

  1. Go to 'Admin panel'
  2. Click on 'that product'
  3. Select the variant
  4. See the error

Expected Result

It should be shown the variant image in the image view container.

Actual Result

It is showing while hovering over the image. Here

Screenshots

No response

Additional context

No response
@Amitk-webkul Amitk-webkul added Bug Something isn't working. 2.x 2.x Versions labels Sep 25, 2023
@amit-webkul amit-webkul self-assigned this Sep 25, 2023
@Amitk-webkul Amitk-webkul added the Hacktoberfest Bagisto Hacktoberfest Event. label Sep 26, 2023
amit-webkul added a commit to amit-webkul/bagisto that referenced this issue Sep 27, 2023
@amit-webkul
Fixed Issue bagisto#8528
a61ae60
@amit-webkul amit-webkul mentioned this issue Sep 27, 2023
Merged
@amit-webkul amit-webkul added the Bug Fixed When bug issue is fixed. label Sep 27, 2023
jitendra-webkul added a commit that referenced this issue Sep 27, 2023
@jitendra-webkul
Merge pull request #8551 from amit-webkul/varient-images
3f5f1b5 
Fixed Issue #8528
@Amitk-webkul
Copy link
Collaborator Author

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amit-webkul amit-webkul

Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working. Hacktoberfest Bagisto Hacktoberfest Event.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amitk-webkul @amit-webkul