Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete Spanish translations #9649

Closed
1 task done
dupotey opened this issue Apr 12, 2024 · 1 comment
Closed
1 task done

Incomplete Spanish translations #9649

dupotey opened this issue Apr 12, 2024 · 1 comment
Assignees
@shivendra-webkul
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Change Request if need any changes on PR

Comments

@dupotey
Copy link
Contributor

dupotey commented Apr 12, 2024

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

2.1, master

Issue Description

The Bagisto Installer, Shop and Admin have incomplete/incorrect Spanish translations. Sometimes the translations are in English or German. As a native Spanish speaker I can create a PR with the fixes.

Preconditions

N/A

Steps to reproduce

Change to Spanish Language.

Expected Result

The expected result is to have all correct Spanish translations.

Actual Result

incomplete/incorrect Spanish translations

Screenshots

Installer:
installer
Shop:
Shop
Admin
admin

Additional context

No response
@dupotey dupotey added the Bug Something isn't working. label Apr 12, 2024
@dupotey dupotey mentioned this issue Apr 12, 2024
Merged
@ashishkumar-webkul ashishkumar-webkul added In Testing When PR in testing. Change Request if need any changes on PR and removed In Testing When PR in testing. labels Apr 12, 2024
jitendra-webkul added a commit that referenced this issue Apr 12, 2024
@jitendra-webkul
Merge pull request #9652 from dupotey/issue-9649_fix_spanish_translat…
63fe753 
…ions

Fixed #9649 - Spanish Translations corrected
@jitendra-webkul jitendra-webkul added the Bug Fixed When bug issue is fixed. label Apr 12, 2024
@dupotey
Copy link
Contributor Author

dupotey commented May 12, 2024

@jitendra-webkul, can this issue be reopened to add a PR for the master branch? The merged PR was for the 2.1 branch.

@dupotey dupotey mentioned this issue May 13, 2024
Merged
1 task
devansh-webkul added a commit that referenced this issue May 14, 2024
@devansh-webkul
Merge pull request #9789 from dupotey/issue-9649_fix_spanish_translat…
f973678 
…ions_master_branch

Fixed #9649 - Spanish Translations corrected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivendra-webkul shivendra-webkul

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Change Request if need any changes on PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jitendra-webkul @dupotey @ashishkumar-webkul @shivendra-webkul