Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange Rates Key Added #4869 #4877

Merged
merged 1 commit into from May 18, 2021

Conversation

devansh-webkul
Copy link
Member

Description

  • I just updated the endpoint and they have made some endpoint premium which means you should have paid a subscription.

Bug

Link: #4869

How to test PR

  • Set key in .env,

    FIXER_API_KEY=
    EXCHANGE_RATES_API_KEY=
  • If you are using fixer exchange then set FIXER_API_KEY key or if you are using default exchange then use EXCHANGE_RATES_API_KEY.

@ghermans ghermans self-requested a review May 18, 2021 12:39
Copy link
Contributor

@ghermans ghermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this more user friendly i would suggest to add this to the admin panel instead of using the config file

@devansh-webkul
Copy link
Member Author

@ghermans,

This will take time as the current implementation relies on the helper class name. So the approach should be different we can raise an enhancement for that. Otherwise i need to mark this as draft.

@ghermans ghermans merged commit 94c638d into bagisto:master May 18, 2021
@devansh-webkul devansh-webkul deleted the exchange-rate-api branch May 19, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants