Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7230 fixed #7232

Closed

Conversation

Sanjaybhattwebkul
Copy link
Contributor

#7230

Add span tag inside tbody/th

@Sanjaybhattwebkul Sanjaybhattwebkul added the QA Passed When QA pass the pull request. label Jan 13, 2023
: {}
"
></th>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the new line.

@@ -613,7 +613,7 @@ h5 {
background: #f8f9fa;
color: $font-color;

&.sortable {
span{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add one space after the span.

>
<span
v-text="column.label"
class="grid_head"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class name should be kebab-case.

@Amitk-webkul
Copy link
Collaborator

@Sanjaybhattwebkul,

Resolve the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed When QA pass the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants