Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added selected count on Mass Action #7437

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Added selected count on Mass Action #7437

merged 4 commits into from
Apr 11, 2023

Conversation

akathuria289
Copy link
Contributor

Issue Reference

#7100

@Amitk-webkul
Copy link
Collaborator

Amitk-webkul commented Mar 31, 2023 •
edited

@akathuria289

If there is not any selected row so no need to show the selected title that is already shown. Here

and No need to show selected tables where the table is not selectable for the data. Here

Add the selected count to the records count.

@Sanjaybhattwebkul Sanjaybhattwebkul added the Change Request if need any changes on PR label Mar 31, 2023
@akathuria289
Copy link
Contributor Author

@Amitk-webkul Done

@Amitk-webkul
Copy link
Collaborator

@akathuria289
Now It is working fine.

@ashishkumar-webkul
Copy link
Collaborator

Checked and Found that this is working fine, I am attaching the video for the reference please check the same.
Video

Mass.update.details.mp4

@akathuria289 akathuria289 removed the Change Request if need any changes on PR label Apr 5, 2023
@Sanjaybhattwebkul Sanjaybhattwebkul added In Testing When PR in testing. QA Passed When QA pass the pull request. and removed In Testing When PR in testing. labels Apr 10, 2023
@devansh-webkul devansh-webkul removed the QA Passed When QA pass the pull request. label Apr 10, 2023
Abhishek Kathuria and others added 2 commits April 11, 2023 11:02
@jitendra-webkul jitendra-webkul merged commit 7641fab into bagisto:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendra-webkul jitendra-webkul jitendra-webkul approved these changes

@devansh-webkul devansh-webkul devansh-webkul approved these changes

@Sanjaybhattwebkul Sanjaybhattwebkul Sanjaybhattwebkul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@akathuria289 @Amitk-webkul @ashishkumar-webkul @jitendra-webkul @devansh-webkul @Sanjaybhattwebkul