Add Configurations and frontend changes #7468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanjaybhattwebkul
previously approved these changes
Apr 5, 2023
|
@vijay-webkul |
|
@vijay-webkul |
vivek-webkul
requested changes
Apr 5, 2023
| @php | ||
| $product = $item->product; | ||
| @php | ||
| $productCount = core()->getConfigData('catalog.products.product-view-page.no-of-cross-sells-product_productpage'); |
There was a problem hiding this comment.
correct the alignment and use snake casing in config field.
packages/Webkul/Velocity/src/Resources/views/shop/products/view/related-products.blade.php
Outdated
Show resolved
Hide resolved
Sanjaybhattwebkul
added
Change Request
Sanjaybhattwebkul
added
QA Passed
Sanjaybhattwebkul
approved these changes
Apr 5, 2023
vivek-webkul
approved these changes
Apr 5, 2023
packages/Webkul/Velocity/src/Resources/views/shop/products/view/cross-sells.blade.php
Show resolved
Hide resolved
packages/Webkul/Velocity/src/Resources/views/shop/products/view/related-products.blade.php
Show resolved
Hide resolved
packages/Webkul/Velocity/src/Resources/views/shop/products/view/up-sells.blade.php
Show resolved
Hide resolved
packages/Webkul/Velocity/src/Resources/views/shop/products/view.blade.php
Show resolved
Hide resolved
devansh-webkul
added
Change Request
|
working on this |
|
@vijay-webkul |
devansh-webkul
added
Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference
#7410
-> Add new feature in configuration and show on the frontend page